Skip to content

Commit 3377715

Browse files
committed
fix: Make the tile header part a section element
Fixed DOM structure unit test
1 parent 3150949 commit 3377715

File tree

3 files changed

+11
-16
lines changed

3 files changed

+11
-16
lines changed

src/components/tile-manager/tile-manager.spec.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,11 @@ describe('Tile Manager component', () => {
2828
}
2929

3030
function getActionButtons(tile: IgcTileComponent) {
31-
const header = tile.shadowRoot?.querySelector('div[part="header"]');
32-
return header?.querySelectorAll(IgcIconButtonComponent.tagName) || [];
31+
return Array.from(
32+
tile.renderRoot
33+
.querySelector('[part="header"]')
34+
?.querySelectorAll(IgcIconButtonComponent.tagName) ?? []
35+
);
3336
}
3437

3538
function createTileManager() {
@@ -192,7 +195,7 @@ describe('Tile Manager component', () => {
192195
part="base draggable resizable"
193196
style="--ig-col-span:1;--ig-row-span:1;"
194197
>
195-
<div part="header">
198+
<section part="header">
196199
<header part="title">
197200
<slot name="title"></slot>
198201
</header>
@@ -221,7 +224,7 @@ describe('Tile Manager component', () => {
221224
</slot>
222225
<slot name="actions"></slot>
223226
</section>
224-
</div>
227+
</section>
225228
<igc-divider type="solid"></igc-divider>
226229
<div part="content-container">
227230
<slot></slot>
@@ -538,8 +541,8 @@ describe('Tile Manager component', () => {
538541
it('can cancel `igcTileMaximize` event', async () => {
539542
const eventSpy = spy(tile, 'emitEvent');
540543

541-
tile.addEventListener('igcTileMaximize', (ev) => {
542-
ev.preventDefault();
544+
tile.addEventListener('igcTileMaximize', (event: Event) => {
545+
event.preventDefault();
543546
});
544547

545548
const btnMaximize = getActionButtons(tile)[0];

src/components/tile-manager/tile-resize.spec.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ import {
1616
simulateKeyboard,
1717
simulateLostPointerCapture,
1818
simulatePointerDown,
19-
simulatePointerEnter,
20-
simulatePointerLeave,
2119
simulatePointerMove,
2220
} from '../common/utils.spec.js';
2321
import IgcResizeContainerComponent, {
@@ -409,12 +407,6 @@ function getResizeContainerDOM(tile: IgcTileComponent) {
409407
};
410408
}
411409

412-
async function setResizeActiveState(tile: IgcTileComponent, state = true) {
413-
const { container, resizeElement } = getResizeContainerDOM(tile);
414-
state ? simulatePointerEnter(container) : simulatePointerLeave(container);
415-
await elementUpdated(resizeElement);
416-
}
417-
418410
function getResizeEventState(
419411
eventSpy: Sinon.SinonSpy<
420412
[

src/components/tile-manager/tile.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ export default class IgcTileComponent extends EventEmitterMixin<
527527

528528
protected _renderHeader() {
529529
return html`
530-
<div part="header">
530+
<section part="header">
531531
<header part="title" ${ref(this._headerRef)}>
532532
<slot name="title"></slot>
533533
</header>
@@ -544,7 +544,7 @@ export default class IgcTileComponent extends EventEmitterMixin<
544544
</slot>
545545
<slot name="actions"></slot>
546546
</section>
547-
</div>
547+
</section>
548548
<igc-divider></igc-divider>
549549
`;
550550
}

0 commit comments

Comments
 (0)