Skip to content

Commit 50c40bd

Browse files
committed
refactor: More code clean-ups around _validate calls
1 parent 6095ba8 commit 50c40bd

File tree

9 files changed

+1
-14
lines changed

9 files changed

+1
-14
lines changed

src/components/checkbox/checkbox-base.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ export class IgcCheckboxBaseComponent extends FormAssociatedCheckboxRequiredMixi
8181
@property({ type: Boolean })
8282
public set checked(value: boolean) {
8383
this._formValue.setValueAndFormState(value);
84-
this._validate();
8584
}
8685

8786
public get checked(): boolean {

src/components/date-picker/date-picker.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,6 @@ export default class IgcDatePickerComponent extends FormAssociatedRequiredMixin(
274274
@property({ converter: convertToDate })
275275
public set value(value: Date | string | null | undefined) {
276276
this._formValue.setValueAndFormState(value as Date | null);
277-
this._validate();
278277
}
279278

280279
public get value(): Date | null {

src/components/date-range-picker/date-range-picker.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -297,11 +297,7 @@ export default class IgcDateRangePickerComponent extends FormAssociatedRequiredM
297297

298298
@property({ converter: convertToDateRange })
299299
public set value(value: DateRangeValue | string | null | undefined) {
300-
const converted = convertToDateRange(value);
301-
302-
this._formValue.setValueAndFormState(converted);
303-
this._validate();
304-
300+
this._formValue.setValueAndFormState(convertToDateRange(value));
305301
this._setCalendarRangeValues();
306302
this._updateMaskedRangeValue();
307303
}

src/components/date-time-input/date-time-input.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ export default class IgcDateTimeInputComponent extends EventEmitterMixin<
139139
public set value(value: Date | string | null | undefined) {
140140
this._formValue.setValueAndFormState(value as Date | null);
141141
this.updateMask();
142-
this._validate();
143142
}
144143

145144
/**
@@ -299,7 +298,6 @@ export default class IgcDateTimeInputComponent extends EventEmitterMixin<
299298
super.connectedCallback();
300299
this.updateDefaultMask();
301300
this.setMask(this.inputFormat);
302-
this._validate();
303301
if (this.value) {
304302
this.updateMask();
305303
}

src/components/file-input/file-input.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,6 @@ export default class IgcFileInputComponent extends EventEmitterMixin<
167167
this._hasActivation = false;
168168
this._setTouchedState();
169169
this._formValue.setValueAndFormState(this.files);
170-
this._validate();
171170

172171
this.requestUpdate();
173172
this.emitEvent('igcChange', { detail: this.files! });

src/components/mask-input/mask-input.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ export default class IgcMaskInputComponent extends IgcMaskInputBaseComponent {
100100
this.maskedValue = this.parser.apply(value);
101101
this.updateMaskedValue();
102102
this._formValue.setValueAndFormState(value);
103-
this._validate();
104103
}
105104

106105
/**

src/components/radio/radio.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ export default class IgcRadioComponent extends FormAssociatedCheckboxRequiredMix
164164
public set checked(value: boolean) {
165165
this._formValue.setValueAndFormState(value);
166166
this._tabIndex = this.checked ? 0 : -1;
167-
this._validate();
168167
if (this.hasUpdated && this.checked) {
169168
this._updateCheckedState();
170169
}

src/components/select/select.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,6 @@ export default class IgcSelectComponent extends FormAssociatedRequiredMixin(
532532

533533
private _updateValue(value?: string): void {
534534
this._formValue.setValueAndFormState(value!);
535-
this._validate();
536535
}
537536

538537
private _clearSelectedItem(): void {

src/components/textarea/textarea.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,6 @@ export default class IgcTextareaComponent extends FormAssociatedRequiredMixin(
234234
@property()
235235
public set value(value: string) {
236236
this._formValue.setValueAndFormState(value);
237-
this._validate();
238237
}
239238

240239
public get value(): string {

0 commit comments

Comments
 (0)