Skip to content

Commit 6c0897d

Browse files
authored
fix(checkbox): remove extra gap (#1479)
1 parent f857a70 commit 6c0897d

File tree

7 files changed

+6
-17
lines changed

7 files changed

+6
-17
lines changed

src/components/checkbox/checkbox-base.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ export class IgcCheckboxBaseComponent extends FormAssociatedCheckboxRequiredMixi
8787

8888
protected override createRenderRoot() {
8989
const root = super.createRenderRoot();
90+
this.hideLabel = isEmpty(this.label);
9091

9192
root.addEventListener('slotchange', () => {
9293
this.hideLabel = isEmpty(this.label);

src/components/checkbox/checkbox.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ export default class IgcCheckboxComponent extends IgcCheckboxBaseComponent {
122122
.hidden=${this.hideLabel}
123123
part=${partNameMap({ label: true, checked })}
124124
id=${this.labelId}
125-
>
126-
<slot></slot>
125+
><slot></slot>
127126
</span>
128127
</label>
129128
${this.renderValidatorContainer()}

src/components/checkbox/themes/checkbox.base.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ $mark-length: 24;
4040
transition: color .2s ease-in-out;
4141
}
4242

43+
[part~='base'] {
44+
gap: rem(8px);
45+
}
46+
4347
[part~='indicator'] {
4448
display: flex;
4549
position: absolute;
@@ -65,7 +69,6 @@ label {
6569
align-items: center;
6670
cursor: pointer;
6771
flex-flow: row nowrap;
68-
gap: rem(8px);
6972
}
7073

7174
[part='indicator checked'] {

src/components/checkbox/themes/shared/checkbox/checkbox.bootstrap.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,6 @@ $theme: $bootstrap;
5555
}
5656
}
5757

58-
[part~='base'] {
59-
gap: rem(16px);
60-
}
61-
6258
:host(:hover) {
6359
[part~='control']::after {
6460
box-shadow: inset 0 0 0 rem(1px) var-get($theme, 'empty-color-hover');

src/components/checkbox/themes/shared/checkbox/checkbox.fluent.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@ $disabled-color: var-get($theme, 'disabled-color');
4646
transform: scale(.8);
4747
}
4848

49-
[part~='base'] {
50-
gap: rem(16px);
51-
}
52-
5349
:host(:hover) {
5450
[part~='indicator'] {
5551
opacity: 1;

src/components/checkbox/themes/shared/checkbox/checkbox.indigo.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ $error-color-hover: var-get($theme, 'error-color-hover');
2121
}
2222
}
2323

24-
[part~='base'] {
25-
gap: rem(16px);
26-
}
27-
2824
[part~='control'] {
2925
--size: #{rem(16px)};
3026

src/components/checkbox/themes/shared/checkbox/checkbox.material.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ label {
5252
}
5353

5454
[part~='base'] {
55-
gap: rem(8px);
56-
5755
&:hover {
5856
[part~='control'] {
5957
&::before {

0 commit comments

Comments
 (0)