refactor: Minor code style changes and a CHANGELOG entry

Author: rkaraivanov

CHANGELOG.md

@@ -6,8 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 ### Added
-- New File Input Component(`igc-file-input`)
+- File Input component
 - Exposed more public API type aliases for component property types like `ButtonVariant`, `PickerMode`, `StepperOrientation`, `HorizontalTransitionAnimation` (carousel and horizontal stepper) and more.
+- Tooltip component
 
 ### Deprecated
 - Some event argument types have been renamed for consistency:

src/components/tooltip/controller.ts

@@ -165,6 +165,9 @@ class TooltipController implements ReactiveController {
         break;
       case 'pointerleave':
         await this._options.onHide.call(this._host);
+        break;
+      default:
+        return;
     }
   }
 
@@ -256,9 +259,28 @@ class TooltipController implements ReactiveController {
 }
 
 function parseTriggers(string: string): Set<string> {
-  return new Set((string ?? '').split(/[,\s]+/).filter((s) => s.trim()));
+  return new Set(
+    (string ?? '').split(TooltipRegexes.triggers).filter((s) => s.trim())
+  );
 }
 
+export const TooltipRegexes = Object.freeze({
+  /** Used for parsing the strings passed in the tooltip `show/hide-trigger` properties. */
+  triggers: /[,\s]+/,
+
+  /** Matches horizontal `PopoverPlacement` start positions. */
+  horizontalStart: /^(left|right)-start$/,
+
+  /** Matches horizontal `PopoverPlacement` end positions. */
+  horizontalEnd: /^(left|right)-end$/,
+
+  /** Matches vertical `PopoverPlacement` start positions. */
+  start: /start$/,
+
+  /** Matches vertical `PopoverPlacement` end positions. */
+  end: /end$/,
+});
+
 export function addTooltipController(
   host: IgcTooltipComponent,
   options: TooltipCallbacks

src/components/tooltip/tooltip.ts

@@ -15,7 +15,7 @@ import IgcIconComponent from '../icon/icon.js';
 import IgcPopoverComponent, {
   type PopoverPlacement,
 } from '../popover/popover.js';
-import { addTooltipController } from './controller.js';
+import { TooltipRegexes, addTooltipController } from './controller.js';
 import { styles as shared } from './themes/shared/tooltip.common.css';
 import { all } from './themes/themes.js';
 import { styles } from './themes/tooltip.base.css.js';
@@ -91,24 +91,24 @@ export default class IgcTooltipComponent extends EventEmitterMixin<
   private _arrowElement!: HTMLElement;
 
   private get _arrowOffset() {
-    if (/-/.test(this.placement)) {
+    if (this.placement.includes('-')) {
       // Horizontal start | end placement
 
-      if (/^(left|right)-start$/.test(this.placement)) {
+      if (TooltipRegexes.horizontalStart.test(this.placement)) {
         return -8;
       }
 
-      if (/^(left|right)-end$/.test(this.placement)) {
+      if (TooltipRegexes.horizontalEnd.test(this.placement)) {
         return 8;
       }
 
       // Vertical start | end placement
 
-      if (/start$/.test(this.placement)) {
+      if (TooltipRegexes.start.test(this.placement)) {
         return isLTR(this) ? -8 : 8;
       }
 
-      if (/end$/.test(this.placement)) {
+      if (TooltipRegexes.end.test(this.placement)) {
         return isLTR(this) ? 8 : -8;
       }
     }
@@ -350,17 +350,17 @@ export default class IgcTooltipComponent extends EventEmitterMixin<
       this._controller.setAnchor(target, true);
     }
 
-    return this._applyTooltipState({ show: true });
+    return await this._applyTooltipState({ show: true });
   }
 
   /** Hides the tooltip if not already hidden. */
   public async hide(): Promise<boolean> {
-    return this._applyTooltipState({ show: false });
+    return await this._applyTooltipState({ show: false });
   }
 
   /** Toggles the tooltip between shown/hidden state */
   public async toggle(): Promise<boolean> {
-    return this.open ? this.hide() : this.show();
+    return await (this.open ? this.hide() : this.show());
   }
 
   protected _showWithEvent(): Promise<boolean> {
@@ -393,7 +393,7 @@ export default class IgcTooltipComponent extends EventEmitterMixin<
     this._stopTimeoutAndAnimation();
 
     this._timeoutId = setTimeout(
-      () => this._hideWithEvent(),
+      this._hideWithEvent.bind(this),
       this._autoHideDelay
     );
   }