Skip to content

Commit 7e53a56

Browse files
committed
refactor: improve the maximized-tile logic
1 parent a253859 commit 7e53a56

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

src/components/tile-manager/tile-manager.ts

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { ContextProvider } from '@lit/context';
22
import { LitElement, html } from 'lit';
3-
import { property, state } from 'lit/decorators.js';
3+
import { property } from 'lit/decorators.js';
44
import { type StyleInfo, styleMap } from 'lit/directives/style-map.js';
55
import { themes } from '../../theming/theming-decorator.js';
66
import { tileManagerContext } from '../common/context.js';
@@ -99,9 +99,6 @@ export default class IgcTileManagerComponent extends EventEmitterMixin<
9999
this._tilesState.assignTiles();
100100
}
101101

102-
@state()
103-
private _isAnyTileMaximized = false;
104-
105102
/**
106103
* Determines whether the tiles slide or swap on drop.
107104
* @attr drag-mode
@@ -180,11 +177,6 @@ export default class IgcTileManagerComponent extends EventEmitterMixin<
180177
});
181178
}
182179

183-
public override connectedCallback() {
184-
super.connectedCallback();
185-
this.updateIsAnyTileMaximized();
186-
}
187-
188180
protected override firstUpdated() {
189181
this._tilesState.assignPositions();
190182
this._tilesState.assignTiles();
@@ -221,11 +213,6 @@ export default class IgcTileManagerComponent extends EventEmitterMixin<
221213
}
222214
}
223215

224-
/** @private @hidden @internal */
225-
public updateIsAnyTileMaximized() {
226-
this._isAnyTileMaximized = this.tiles.some((tile) => tile.maximized);
227-
}
228-
229216
public saveLayout(): string {
230217
return this._serializer.saveAsJSON();
231218
}
@@ -237,7 +224,7 @@ export default class IgcTileManagerComponent extends EventEmitterMixin<
237224
protected override render() {
238225
const parts = partNameMap({
239226
base: true,
240-
'maximized-tile': this._isAnyTileMaximized,
227+
'maximized-tile': this.tiles.some((tile) => tile.maximized),
241228
});
242229

243230
return html`

src/components/tile-manager/tile.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ export default class IgcTileComponent extends EventEmitterMixin<
206206
this._maximized = value;
207207

208208
if (this._managerContext) {
209-
this._managerContext.instance.updateIsAnyTileMaximized();
209+
this._managerContext.instance.requestUpdate();
210210
}
211211
}
212212

0 commit comments

Comments
 (0)