Skip to content

Commit 7f1a517

Browse files
committed
fix(*): remove dragImage async and fix test
1 parent 014dfd3 commit 7f1a517

File tree

2 files changed

+10
-17
lines changed

2 files changed

+10
-17
lines changed

src/components/tile-manager/tile-manager.spec.ts

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -152,19 +152,12 @@ describe('Tile Manager component', () => {
152152
part="resize"
153153
>
154154
<div
155-
part="tile-container"
155+
part="base draggable resizable"
156156
style="--ig-col-span:1;--ig-row-span:1;"
157157
>
158-
<div inert part="ghost">
159-
</div>
160-
<div
161-
part="base draggable resizable"
162-
style="transform:;"
163-
>
164-
<slot name="header"></slot>
165-
<div part="content-container">
166-
<slot></slot>
167-
</div>
158+
<slot name="header"></slot>
159+
<div part="content-container">
160+
<slot></slot>
168161
</div>
169162
</div>
170163
</igc-resize>`

src/components/tile-manager/tile.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ export default class IgcTileComponent extends EventEmitterMixin<
295295
});
296296
}
297297

298-
private async assignDragImage(e: DragEvent) {
298+
private assignDragImage(e: DragEvent) {
299299
const rect = this.getBoundingClientRect();
300300
const offsetX = e.clientX - rect.left;
301301
const offsetY = e.clientY - rect.top;
@@ -305,19 +305,19 @@ export default class IgcTileComponent extends EventEmitterMixin<
305305
Object.assign(this._dragImage.style, {
306306
width: compStyles.width,
307307
height: compStyles.height,
308+
position: 'absolute',
309+
top: '-99999px',
310+
left: '-99999px',
308311
});
309-
this._dragImage.style.position = 'absolute';
310-
this._dragImage.style.top = '-99999px';
311-
this._dragImage.style.left = '-99999px';
312312

313313
document.body.append(this._dragImage);
314314

315315
e.dataTransfer!.setDragImage(this._dragImage, offsetX, offsetY);
316316
e.dataTransfer!.effectAllowed = 'move';
317317
}
318318

319-
private async handleDragStart(e: DragEvent) {
320-
await this.assignDragImage(e);
319+
private handleDragStart(e: DragEvent) {
320+
this.assignDragImage(e);
321321

322322
this.emitEvent('tileDragStart', { detail: this });
323323
this._dragGhost = this.ghostFactory();

0 commit comments

Comments
 (0)