Skip to content

Commit 9afd1fb

Browse files
committed
fix(buttons): address latest fluent comments and remove unnecessary icon styles
1 parent 32bf815 commit 9afd1fb

File tree

2 files changed

+5
-34
lines changed

2 files changed

+5
-34
lines changed

src/components/button/themes/button/shared/button.common.scss

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -79,18 +79,10 @@ $outlined-theme: $material-outlined;
7979
background: var-get($flat-theme, 'focus-visible-background');
8080
border-color: var-get($flat-theme, 'focus-visible-border-color');
8181

82-
::slotted(igc-icon) {
83-
color: var-get($flat-theme, 'icon-color');
84-
}
85-
8682
&:hover {
8783
color: var-get($flat-theme, 'focus-hover-foreground');
8884
background: var-get($flat-theme, 'focus-hover-background');
8985
border-color: var-get($flat-theme, 'focus-visible-border-color');
90-
91-
::slotted(igc-icon) {
92-
color: var-get($flat-theme, 'icon-color-hover');
93-
}
9486
}
9587

9688
&:active {
@@ -140,17 +132,9 @@ $outlined-theme: $material-outlined;
140132
background: var-get($outlined-theme, 'focus-visible-background');
141133
border-color: var-get($outlined-theme, 'focus-visible-border-color');
142134

143-
::slotted(igc-icon) {
144-
color: var-get($outlined-theme, 'icon-color');
145-
}
146-
147135
&:hover {
148136
color: var-get($outlined-theme, 'focus-hover-foreground');
149137
background: var-get($outlined-theme, 'focus-hover-background');
150-
151-
::slotted(igc-icon) {
152-
color: var-get($outlined-theme, 'icon-color-hover');
153-
}
154138
}
155139

156140
&:active {
@@ -200,17 +184,9 @@ $outlined-theme: $material-outlined;
200184
background: var-get($contained-theme, 'focus-visible-background');
201185
border-color: var-get($contained-theme, 'focus-visible-border-color');
202186

203-
::slotted(igc-icon) {
204-
color: var-get($contained-theme, 'icon-color');
205-
}
206-
207187
&:hover {
208188
color: var-get($contained-theme, 'focus-hover-foreground');
209189
background: var-get($contained-theme, 'focus-hover-background');
210-
211-
::slotted(igc-icon) {
212-
color: var-get($contained-theme, 'icon-color-hover');
213-
}
214190
}
215191

216192
&:active {
@@ -260,17 +236,9 @@ $outlined-theme: $material-outlined;
260236
background: var-get($fab-theme, 'focus-visible-background');
261237
border-color: var-get($fab-theme, 'focus-visible-border-color');
262238

263-
::slotted(igc-icon) {
264-
color: var-get($fab-theme, 'icon-color');
265-
}
266-
267239
&:hover {
268240
color: var-get($fab-theme, 'focus-hover-foreground');
269241
background: var-get($fab-theme, 'focus-hover-background');
270-
271-
::slotted(igc-icon) {
272-
color: var-get($fab-theme, 'icon-color-hover');
273-
}
274242
}
275243

276244
&:active {

src/components/button/themes/button/shared/button.fluent.scss

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,14 @@ $outlined-btn-indent: rem(2px);
5050
:host(:not([disabled])[variant='flat']) [part='base focused'],
5151
:host(:not(:disabled)[variant='flat']) [part='base focused'] {
5252
&,
53-
&:hover,
54-
&:active {
53+
&:hover {
5554
border: rem(1px) solid var-get($flat-theme, 'active-border-color');
5655
}
5756

57+
&:active {
58+
border: rem(1px) solid var-get($flat-theme, 'focus-border-color');
59+
}
60+
5861
&::after {
5962
box-shadow: 0 0 0 rem(1px) var-get($flat-theme, 'focus-visible-border-color');
6063
}

0 commit comments

Comments
 (0)