Skip to content

Commit a4ea0e6

Browse files
committed
fix(tm): ensure fullscreen and maximized events are emitted with the new state
1 parent 29b08a4 commit a4ea0e6

File tree

2 files changed

+14
-26
lines changed

2 files changed

+14
-26
lines changed

src/components/tile-manager/tile-header.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export default class IgcTileHeaderComponent extends LitElement {
7676

7777
private emitMaximizedEvent() {
7878
return this._tile?.emitEvent('igcTileMaximize', {
79-
detail: { tile: this._tile, state: this._tile.maximized },
79+
detail: { tile: this._tile, state: !this._tile.maximized },
8080
cancelable: true,
8181
});
8282
}

src/components/tile-manager/tile-manager.spec.ts

Lines changed: 13 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ describe('Tile Manager component', () => {
383383
simulateClick(fullscreenButton!);
384384
await elementUpdated(tileManager);
385385

386-
expect(eventSpy).to.have.been.calledWith(
386+
expect(eventSpy).calledWith(
387387
'igcTileFullscreen',
388388
match({
389389
detail: { tile: tile, state: true },
@@ -432,29 +432,20 @@ describe('Tile Manager component', () => {
432432
await elementUpdated(tile);
433433
await elementUpdated(tileManager);
434434

435-
expect(eventSpy).calledWith('igcTileMaximize');
436-
// TODO: Fix the state in the event arguments
437-
// expect(eventSpy).to.have.been.calledWith(
438-
// 'igcTileMaximize',
439-
// {
440-
// detail: { tile: tile, state: true },
441-
// cancelable: true,
442-
// }
443-
// );
444-
435+
expect(eventSpy).calledWith('igcTileMaximize', {
436+
detail: { tile: tile, state: true },
437+
cancelable: true,
438+
});
445439
expect(tile.maximized).to.be.true;
446440

447441
simulateClick(btnMaximize);
448442
await elementUpdated(tileManager);
449443

450444
expect(eventSpy).to.have.been.calledTwice;
451-
expect(eventSpy).calledWith('igcTileMaximize');
452-
// TODO: Fix the state in the event arguments
453-
// expect(eventSpy).calledWith('igcTileMaximize', {
454-
// detail: { tile: tile, state: false },
455-
// cancelable: true,
456-
// });
457-
445+
expect(eventSpy).calledWith('igcTileMaximize', {
446+
detail: { tile: tile, state: false },
447+
cancelable: true,
448+
});
458449
expect(tile.maximized).to.be.false;
459450
});
460451

@@ -470,13 +461,10 @@ describe('Tile Manager component', () => {
470461
simulateClick(btnMaximize);
471462
await elementUpdated(tileManager);
472463

473-
expect(eventSpy).calledWith('igcTileMaximize');
474-
// TODO: Fix the state in the event arguments
475-
// expect(eventSpy).calledOnceWithExactly('igcTileMaximize', {
476-
// detail: { tile: tile, state: true },
477-
// cancelable: true,
478-
// });
479-
464+
expect(eventSpy).calledOnceWithExactly('igcTileMaximize', {
465+
detail: { tile: tile, state: true },
466+
cancelable: true,
467+
});
480468
expect(tile.maximized).to.be.false;
481469
});
482470

0 commit comments

Comments
 (0)