Skip to content

Commit f34043e

Browse files
committed
fix(date-time-input): Tests
1 parent 6d02c8e commit f34043e

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

src/components/date-time-input/date-time-input.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1071,7 +1071,6 @@ describe('Date Time Input component', () => {
10711071
const spec = createFormAssociatedTestBed<IgcDateTimeInputComponent>(html`
10721072
<igc-date-time-input
10731073
name="date-time"
1074-
required
10751074
.defaultValue=${null}
10761075
></igc-date-time-input>
10771076
`);
@@ -1081,12 +1080,13 @@ describe('Date Time Input component', () => {
10811080
});
10821081

10831082
it('fails required validation', () => {
1083+
spec.setProperties({ required: true });
10841084
spec.assertIsPristine();
10851085
spec.assertSubmitFails();
10861086
});
10871087

10881088
it('passes required validation when updating defaultValue', () => {
1089-
spec.setProperties({ defaultValue: today.native });
1089+
spec.setProperties({ required: true, defaultValue: today.native });
10901090
spec.assertIsPristine();
10911091

10921092
spec.assertSubmitPasses();
@@ -1112,7 +1112,7 @@ describe('Date Time Input component', () => {
11121112
it('fails max validation', () => {
11131113
spec.setProperties({
11141114
max: today.native,
1115-
defaultValue: today.native,
1115+
defaultValue: today.add('day', 1).native,
11161116
});
11171117

11181118
spec.assertIsPristine();
@@ -1122,7 +1122,7 @@ describe('Date Time Input component', () => {
11221122
it('passes max validation', () => {
11231123
spec.setProperties({
11241124
max: today.native,
1125-
defaultValue: today.add('day', -1).native,
1125+
defaultValue: today.native,
11261126
});
11271127

11281128
spec.assertIsPristine();

src/components/date-time-input/date-time-input.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { eventOptions, property } from 'lit/decorators.js';
33
import { ifDefined } from 'lit/directives/if-defined.js';
44
import { live } from 'lit/directives/live.js';
55

6-
import { convertToDate, getDateFormValue } from '../calendar/helpers.js';
6+
import { convertToDate } from '../calendar/helpers.js';
77
import {
88
addKeybindings,
99
altKey,
@@ -20,6 +20,7 @@ import { EventEmitterMixin } from '../common/mixins/event-emitter.js';
2020
import {
2121
type FormValue,
2222
createFormValueState,
23+
defaultDateTimeTransformers,
2324
} from '../common/mixins/forms/form-value.js';
2425
import { noop, partNameMap } from '../common/util.js';
2526
import type { IgcInputComponentEventMap } from '../input/input-base.js';
@@ -282,11 +283,7 @@ export default class IgcDateTimeInputComponent extends EventEmitterMixin<
282283

283284
this._formValue = createFormValueState(this, {
284285
initialValue: null,
285-
transformers: {
286-
setValue: convertToDate,
287-
setDefaultValue: convertToDate,
288-
setFormValue: getDateFormValue,
289-
},
286+
transformers: defaultDateTimeTransformers,
290287
});
291288

292289
addKeybindings(this, {

0 commit comments

Comments
 (0)