refactor(combo): set item count in a CSS variable

simeonoff · simeonoff · commit f36c7cad7827 · 2025-09-01T11:34:50.000+03:00
diff --git a/src/components/combo/themes/combo.base.scss b/src/components/combo/themes/combo.base.scss
@@ -2,6 +2,8 @@
 @use 'styles/utilities' as *;
 
 :host {
+    --item-count: 6;
+
     display: block;
     font-family: var(--ig-font-family);
 
@@ -73,7 +75,7 @@
 }
 
 [part='list'] {
-    min-height: calc(var(--size) * 6) !important;
+    min-height: calc(var(--size) * var(--item-count)) !important;
     outline-style: none;
 }
 
diff --git a/src/components/combo/themes/shared/combo.indigo.scss b/src/components/combo/themes/shared/combo.indigo.scss
@@ -62,7 +62,7 @@ $dropdown-theme: dropdown-theme.$indigo;
 }
 
 [part='list'] {
-    min-height: calc(var(--size) * 6 + rem(16px)) !important;
+    min-height: calc(var(--size) * var(--item-count) + rem(16px)) !important;
 }
 
 [part='filter-input'] {

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,8 @@`
`2`	`2`	`@use 'styles/utilities' as *;`
`3`	`3`
`4`	`4`	`:host {`
	`5`	`+ --item-count: 6;`
	`6`	`+`
`5`	`7`	`display: block;`
`6`	`8`	`font-family: var(--ig-font-family);`
`7`	`9`
`@@ -73,7 +75,7 @@`
`73`	`75`	`}`
`74`	`76`
`75`	`77`	`[part='list'] {`
`76`		`- min-height: calc(var(--size) * 6) !important;`
	`78`	`+ min-height: calc(var(--size) * var(--item-count)) !important;`
`77`	`79`	`outline-style: none;`
`78`	`80`	`}`
`79`	`81`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ $dropdown-theme: dropdown-theme.$indigo;`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`[part='list'] {`
`65`		`- min-height: calc(var(--size) * 6 + rem(16px)) !important;`
	`65`	`+ min-height: calc(var(--size) * var(--item-count) + rem(16px)) !important;`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`[part='filter-input'] {`