Skip to content

Commit fc0a436

Browse files
committed
refactor(progressbar): add comments to clarify why we use px for --stroke-thickness
1 parent c457151 commit fc0a436

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

src/components/progress/themes/circular/shared/circular.progress.bootstrap.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
$theme: $bootstrap;
55

66
:host {
7+
// Do not use rem values here
8+
// This will break the component in Safari
9+
// https://github.com/IgniteUI/igniteui-webcomponents/issues/377
710
--stroke-thickness: 2px;
811
--scale-factor: 3.05;
912
}

src/components/progress/themes/circular/shared/circular.progress.fluent.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
$theme: $fluent;
77

88
:host {
9+
// Do not use rem values here
10+
// This will break the component in Safari
11+
// https://github.com/IgniteUI/igniteui-webcomponents/issues/377
912
--stroke-thickness: 2px;
1013
--scale-factor: 2.75;
1114
}

src/components/progress/themes/circular/shared/circular.progress.indigo.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
$theme: $indigo;
55

66
:host {
7-
--stroke-thickness: rem(3px);
7+
// Do not use rem values here
8+
// This will break the component in Safari
9+
// https://github.com/IgniteUI/igniteui-webcomponents/issues/377
10+
--stroke-thickness: 3px;
811
--scale-factor: 3.4;
912
}
1013

0 commit comments

Comments
 (0)