Cards - Take migration info into consideration; Add "Used plugins/zipmods" (#235)

- Added support for zipmod GUID migration to dependency check to handle cards using zipmods with migrated GUIDs
- Introduced UsedPlugins and UsedZipmods properties to show all dependencies, not just missing ones
- Improved card load performance by pre-computing GUID HashSets instead of repeatedly iterating through collections

Author: ManlyMarco

src/KKManager.Core/Data/Cards/Card.cs

@@ -27,11 +27,16 @@ public abstract class Card : IFileInfoBase
         [DisplayName("Extended Data Size")]
         public FileSize ExtendedSize { get; }
 
-        [ReadOnly(true), TypeConverter(typeof(ReadOnlyStringCollectionConverterWithPreview))] 
+        [ReadOnly(true), TypeConverter(typeof(ReadOnlyStringCollectionConverterWithPreview))]
+        public string[] UsedZipmods { get; set; }
+        [ReadOnly(true), TypeConverter(typeof(ReadOnlyStringCollectionConverterWithPreview))]
+        public string[] UsedPlugins { get; set; }
+
+        [ReadOnly(true), TypeConverter(typeof(ReadOnlyStringCollectionConverterWithPreview))]
         public string[] MissingZipmods { get; set; }
-        [ReadOnly(true), TypeConverter(typeof(ReadOnlyStringCollectionConverterWithPreview))] 
+        [ReadOnly(true), TypeConverter(typeof(ReadOnlyStringCollectionConverterWithPreview))]
         public string[] MissingPlugins { get; set; }
-        [ReadOnly(true), TypeConverter(typeof(ReadOnlyStringCollectionConverterWithPreview))] 
+        [ReadOnly(true), TypeConverter(typeof(ReadOnlyStringCollectionConverterWithPreview))]
         public string[] MissingPluginsMaybe { get; set; }
 
         public virtual Image GetCardImage()

src/KKManager.Core/Data/Cards/CardLoader.cs

@@ -20,9 +20,9 @@
 using KKManager.Data.Cards.RG;
 using KKManager.Data.Cards.SVS;
 using KKManager.Data.Plugins;
-using KKManager.Data.Sardines;
 using KKManager.Data.Zipmods;
 using KKManager.Util;
+using Sideloader.AutoResolver;
 
 namespace KKManager.Data.Cards
 {
@@ -78,9 +78,20 @@ void ReadCardsFromDir()
                             try
                             {
                                 var allPlugins = PluginLoader.Plugins.ToEnumerable().ToList();
+                                var existingPluginGuids = allPlugins.Select(p => p.Guid).ToHashSet();
+
                                 var allZipmods = SideloaderModLoader.Zipmods.ToEnumerable().ToList();
+                                var existingZipmodGuids = allZipmods.Select(z => z.Guid).ToHashSet();
+                                // Also consider migrated GUIDs as existing (but only if zipmod with the target GUID is actually present).
+                                // No easy way to check StripAll so just assume the required zipmod is present
+                                var migratedGuids = allZipmods.SelectMany(x => x.Manifest.MigrationList)
+                                                              .Where(x => !string.IsNullOrEmpty(x.GUIDOld) && (x.MigrationType == MigrationType.StripAll || existingZipmodGuids.Contains(x.GUIDNew)))
+                                                              .Select(x => x.GUIDOld);
+                                foreach (var migratedGuid in migratedGuids)
+                                    existingZipmodGuids.Add(migratedGuid);
+
                                 foreach (var card in s.ToEnumerable())
-                                    CheckIfRequiredModsExist(card, allPlugins, allZipmods);
+                                    CheckIfRequiredModsExist(card, allPlugins, allZipmods, existingPluginGuids, existingZipmodGuids);
                             }
                             catch (TargetInvocationException ex)
                             {
@@ -99,30 +110,35 @@ void ReadCardsFromDir()
             return s;
         }
 
-        private static void CheckIfRequiredModsExist(Card card, List<PluginInfo> allPlugins, List<SideloaderModInfo> allZipmods)
+        private static void CheckIfRequiredModsExist(Card card, List<PluginInfo> allPlugins, List<SideloaderModInfo> allZipmods, HashSet<string> existingPluginGuids, HashSet<string> existingZipmodGuids)
         {
             if (card.Extended == null) return;
 
             var cardExtDatas = card.Extended.Where(x => x.Value != null).ToList();
 
-            var extGroups = cardExtDatas.ToLookup(x => x.Value.RequiredPluginGUIDs.Count > 0);
+            var cardExtDatasPlugins = cardExtDatas.ToLookup(x => x.Value.RequiredPluginGUIDs.Count > 0);
+            var definiteRequirements = cardExtDatasPlugins[true].SelectMany(x => x.Value.RequiredPluginGUIDs).Distinct().OrderBy(x => x).ToArray();
+            card.UsedPlugins = definiteRequirements;
 
-            var missingPlugs = extGroups[true].SelectMany(x => x.Value.RequiredPluginGUIDs).Where(x => allPlugins.All(p => x != p.Guid)).Distinct().ToArray();
+            var missingPlugs = definiteRequirements.Where(x => !existingPluginGuids.Contains(x)).ToArray();
             if (missingPlugs.Length > 0)
             {
                 card.MissingPlugins = missingPlugs;
                 //Console.WriteLine(card.Location.Name + " requires plugins that are missing: " + string.Join("; ", missingPlugs));
             }
 
             var allExtCandidates = allPlugins.SelectMany(z => z.ExtDataGuidCandidates ?? Enumerable.Empty<string>()).ToHashSet();
-            var missingPlugsMaybe = extGroups[false].Where(x => !allExtCandidates.Contains(x.Key)).Select(x => x.Key).Distinct().ToArray();
+            var possibleRequirements = cardExtDatasPlugins[false];
+            var missingPlugsMaybe = possibleRequirements.Where(x => !allExtCandidates.Contains(x.Key)).Select(x => x.Key).Distinct().ToArray();
             if (missingPlugsMaybe.Length > 0)
             {
                 card.MissingPluginsMaybe = missingPlugsMaybe;
             }
 
-            var zipmodGuids = cardExtDatas.SelectMany(x => x.Value.RequiredZipmodGUIDs);
-            var missingZipmods = zipmodGuids.Where(x => allZipmods.All(p => x != p.Guid)).Distinct().ToArray();
+            var cardZipmodGuids = cardExtDatas.SelectMany(x => x.Value.RequiredZipmodGUIDs).Distinct().OrderBy(x => x).ToArray();
+            card.UsedZipmods = cardZipmodGuids;
+
+            var missingZipmods = cardZipmodGuids.Where(x => !existingZipmodGuids.Contains(x)).ToArray();
             if (missingZipmods.Length > 0)
             {
                 card.MissingZipmods = missingZipmods;