Skip to content

Commit 3686760

Browse files
IECoreAppleseed : Support spline input connections
1 parent 878782c commit 3686760

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

contrib/IECoreAppleseed/src/IECoreAppleseed/ShaderNetworkAlgo.cpp

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,9 @@ namespace ShaderNetworkAlgo
6565

6666
renderer::ShaderGroup *convert( const IECoreScene::ShaderNetwork *shaderNetwork )
6767
{
68-
ShaderNetworkPtr networkCopy;
69-
if( true ) // todo : make conditional on OSL < 1.10
70-
{
71-
networkCopy = shaderNetwork->copy();
72-
IECoreScene::ShaderNetworkAlgo::convertOSLComponentConnections( networkCopy.get() );
73-
shaderNetwork = networkCopy.get();
74-
}
68+
ShaderNetworkPtr networkCopy = shaderNetwork->copy();
69+
IECoreScene::ShaderNetworkAlgo::convertToOSLConventions( networkCopy.get(), 10900 );
70+
shaderNetwork = networkCopy.get();
7571

7672
asf::auto_release_ptr<asr::ShaderGroup> shaderGroup;
7773
shaderGroup = asr::ShaderGroupFactory::create( "shader_group" );
@@ -89,11 +85,7 @@ renderer::ShaderGroup *convert( const IECoreScene::ShaderNetwork *shaderNetwork
8985
shaderType += 4;
9086
}
9187

92-
IECore::ConstCompoundDataPtr expandedParameters = IECoreScene::ShaderNetworkAlgo::expandSplineParameters(
93-
shader->parametersData()
94-
);
95-
96-
asr::ParamArray params( ParameterAlgo::convertShaderParameters( expandedParameters->readable() ) );
88+
asr::ParamArray params( ParameterAlgo::convertShaderParameters( shader->parametersData()->readable() ) );
9789
shaderGroup->add_shader( shaderType, shader->getName().c_str(), handle.c_str(), params );
9890

9991
for( const auto &c : shaderNetwork->inputConnections( handle ) )

contrib/IECoreAppleseed/test/IECoreAppleseed/ShaderNetworkAlgoTest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def testSplines( self ) :
4848

4949
n = IECoreScene.ShaderNetwork(
5050
shaders = {
51-
"test" : IECoreScene.Shader( "test", "test",
51+
"test" : IECoreScene.Shader( "test", "osl:shader",
5252
IECore.CompoundData(
5353
{
5454
"testColorSpline" : IECore.SplinefColor3fData( IECore.SplinefColor3f( IECore.CubicBasisf.linear(), ( ( 0, imath.Color3f(1) ), ( 10, imath.Color3f(2) ), ( 20, imath.Color3f(0) ) ) ) ),

0 commit comments

Comments
 (0)