LiveScene: Fix bug when querying scene with multiple parent in the hierarchy.

For example, previously with the following hierarchy:

/sphereA/a
/sphereA/b

we would get the following result for the childNames of the root level

["sphereA", "sphereA"] instead of ["sphereA"]

or with the following hierarchy:

/sphereA/a
/sphereA/b
/sphereB/c

we would get the following result for the childNames of "sphereA":

["a","b","c"] instead of ["a","b"]

Author: lucienfostier

src/IECoreNuke/LiveScene.cpp

@@ -549,10 +549,21 @@ void LiveScene::childNames( NameList &childNames ) const
 	IECoreScene::SceneInterface::stringToPath( m_rootPath, rootPath );
 	for ( auto& path : allPaths )
 	{
+		// ignore children with a different root path
+		if ( !( path.rfind( m_rootPath, 0 ) == 0 ) )
+		{
+			continue;
+		}
+
 		allPath.clear();
 		IECoreScene::SceneInterface::stringToPath( path, allPath );
 		if ( rootPath.size() < allPath.size() )
 		{
+			// ignore duplicates.
+			if ( find( childNames.begin(), childNames.end(), allPath[rootPath.size()] ) != childNames.end() )
+			{
+				continue;
+			}
 			childNames.push_back( allPath[rootPath.size()] );
 		}
 	}
@@ -583,7 +594,16 @@ SceneInterfacePtr LiveScene::child( const Name &name, MissingBehaviour missingBe
 				throw Exception( "IECoreNuke::LiveScene: Name\"" + name.string() + "\" is missing and LiveScene is read-only" );
 		}
 	}
-	return new LiveScene( m_op, m_rootPath + "/" + name.string() );
+
+	IECoreScene::SceneInterface::Path newPath;
+	IECoreScene::SceneInterface::stringToPath( m_rootPath, newPath );
+
+	newPath.push_back( name.string() );
+
+	std::string newRoot;
+	IECoreScene::SceneInterface::pathToString( newPath, newRoot );
+
+	return new LiveScene( m_op, newRoot );
 }
 
 ConstSceneInterfacePtr LiveScene::child( const Name &name, MissingBehaviour missingBehaviour ) const
@@ -603,7 +623,16 @@ ConstSceneInterfacePtr LiveScene::child( const Name &name, MissingBehaviour miss
 				throw Exception( "IECoreNuke::LiveScene: Name\"" + name.string() + "\" is missing and LiveScene is read-only" );
 		}
 	}
-	return new LiveScene( m_op, m_rootPath + "/" + name.string() );
+
+	IECoreScene::SceneInterface::Path newPath;
+	IECoreScene::SceneInterface::stringToPath( m_rootPath, newPath );
+
+	newPath.push_back( name.string() );
+
+	std::string newRoot;
+	IECoreScene::SceneInterface::pathToString( newPath, newRoot );
+
+	return new LiveScene( m_op, newRoot );
 }
 
 SceneInterfacePtr LiveScene::createChild( const Name &name )
@@ -636,6 +665,7 @@ ConstSceneInterfacePtr LiveScene::scene( const Path &path, MissingBehaviour miss
 
 	std::string pathStr;
 	IECoreScene::SceneInterface::pathToString( path, pathStr );
+
 	return new LiveScene( m_op, pathStr );
 }
 

test/IECoreNuke/LiveSceneKnobTest.py

@@ -191,6 +191,47 @@ def testBounds( self ):
 
 			self.assertEqual( subScene.readBound(0), subExpectedScene.readBound(0) )
 
+	def testDuplicatedParent( self ):
+		import IECoreScene
+
+		sceneFile = "test/IECoreNuke/scripts/data/duplicateParent.scc"
+		sceneReader = nuke.createNode( "ieSceneCacheReader" )
+		sceneReader.knob( "file" ).setValue( sceneFile )
+		expectedScene = IECoreScene.SharedSceneInterfaces.get( sceneFile )
+
+		sceneReader.forceValidate()
+		widget = sceneReader.knob( "sceneView" )
+		widget.setSelectedItems( ['/root/groupA/cube','/root/groupA/sphere', '/root/groupB/sphere'] )
+
+		n = nuke.createNode( "ieLiveScene" )
+		n.setInput( 0, sceneReader )
+
+		liveScene = n.knob( "scene" ).getValue()
+		self.assertEqual( set( liveScene.childNames() ), set( expectedScene.childNames() ) )
+
+	def testFilterDifferentParent( self ):
+		import IECoreScene
+
+		sceneFile = "test/IECoreNuke/scripts/data/duplicateParent.scc"
+		sceneReader = nuke.createNode( "ieSceneCacheReader" )
+		sceneReader.knob( "file" ).setValue( sceneFile )
+		expectedScene = IECoreScene.SharedSceneInterfaces.get( sceneFile )
+
+		sceneReader.forceValidate()
+		widget = sceneReader.knob( "sceneView" )
+		widget.setSelectedItems( ['/root/groupA/cube','/root/groupA/sphere', '/root/groupB/sphere'] )
+
+		n = nuke.createNode( "ieLiveScene" )
+		n.setInput( 0, sceneReader )
+
+		liveScene = n.knob( "scene" ).getValue()
+
+		for subPath in ( ["groupA"], ["groupB"] ):
+			subScene = liveScene.scene( subPath )
+			subExpectedScene = expectedScene.scene( subPath )
+
+			self.assertCountEqual( subScene.childNames(), subExpectedScene.childNames() )
+		
 	def testAnimatedBounds( self ):
 		import IECoreScene