Skip to content

Commit 26bca87

Browse files
authored
Merge pull request #19 from ImageMarkup/fix-typing-errors
2 parents b720a1a + cb5a89e commit 26bca87

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

isic_metadata/metadata.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
BaseModel,
1010
BeforeValidator,
1111
ConfigDict,
12-
FieldValidationInfo,
1312
ValidationError,
13+
ValidationInfo,
1414
WrapValidator,
1515
field_validator,
1616
model_validator,
@@ -202,7 +202,7 @@ def lower(cls, v):
202202

203203
@field_validator("diagnosis")
204204
@classmethod
205-
def validate_no_benign_melanoma(cls, v, info: FieldValidationInfo):
205+
def validate_no_benign_melanoma(cls, v, info: ValidationInfo):
206206
if info.data.get("benign_malignant"):
207207
if v == "melanoma" and info.data["benign_malignant"] == "benign":
208208
raise ValueError("A benign melanoma cannot exist.")
@@ -218,7 +218,7 @@ def validate_no_benign_melanoma(cls, v, info: FieldValidationInfo):
218218

219219
@field_validator("nevus_type")
220220
@classmethod
221-
def validate_non_nevus_diagnoses(cls, v, info: FieldValidationInfo):
221+
def validate_non_nevus_diagnoses(cls, v, info: ValidationInfo):
222222
if not info.data.get("diagnosis"):
223223
raise ValueError("Nevus type requires a diagnosis.")
224224

@@ -228,7 +228,7 @@ def validate_non_nevus_diagnoses(cls, v, info: FieldValidationInfo):
228228

229229
@field_validator("mel_class", "mel_mitotic_index", "mel_thick_mm", "mel_type", "mel_ulcer")
230230
@classmethod
231-
def validate_melanoma_fields(cls, v, info: FieldValidationInfo):
231+
def validate_melanoma_fields(cls, v, info: ValidationInfo):
232232
if not info.data.get("diagnosis"):
233233
raise ValueError(f"{info.field_name} requires a diagnosis of melanoma.")
234234

@@ -238,7 +238,7 @@ def validate_melanoma_fields(cls, v, info: FieldValidationInfo):
238238

239239
@field_validator("diagnosis_confirm_type")
240240
@classmethod
241-
def validate_non_histopathology_diagnoses(cls, v, info: FieldValidationInfo):
241+
def validate_non_histopathology_diagnoses(cls, v, info: ValidationInfo):
242242
# TODO: renable this after https://github.com/ImageMarkup/tracker/issues/141 is fixed.
243243
# if not info.data.get("diagnosis"):
244244
# raise ValueError("Diagnosis confirm type requires a diagnosis.")
@@ -258,7 +258,7 @@ def validate_non_histopathology_diagnoses(cls, v, info: FieldValidationInfo):
258258

259259
@field_validator("dermoscopic_type")
260260
@classmethod
261-
def validate_dermoscopic_fields(cls, v, info: FieldValidationInfo):
261+
def validate_dermoscopic_fields(cls, v, info: ValidationInfo):
262262
if info.data.get("image_type") != ImageTypeEnum.dermoscopic and v:
263263
image_type = info.data.get("image_type", "")
264264
raise ValueError(
@@ -268,7 +268,7 @@ def validate_dermoscopic_fields(cls, v, info: FieldValidationInfo):
268268

269269
@field_validator("tbp_tile_type")
270270
@classmethod
271-
def validate_tbp_tile_fields(cls, v, info: FieldValidationInfo):
271+
def validate_tbp_tile_fields(cls, v, info: ValidationInfo):
272272
if (
273273
info.data.get("image_type")
274274
not in [ImageTypeEnum.tbp_tile_close_up, ImageTypeEnum.tbp_tile_overview]

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@
3333
"Programming Language :: Python",
3434
],
3535
python_requires=">=3.9",
36-
install_requires=["pandas", "numpy", "pydantic>=2"],
36+
install_requires=["pandas", "numpy", "pydantic>=2.4"],
3737
packages=find_packages(),
3838
)

0 commit comments

Comments
 (0)