Clippy

Author: kornelski

imagequant-sys/src/ffi.rs

@@ -22,14 +22,14 @@ pub use imagequant::Error as liq_error;
 pub struct liq_attr {
     magic_header: MagicTag,
     inner: Attributes,
-    c_api_free: unsafe extern fn(*mut c_void),
+    c_api_free: unsafe extern "C" fn(*mut c_void),
 }
 
 #[repr(C)]
 pub struct liq_image<'pixels> {
     magic_header: MagicTag,
     inner: ManuallyDrop<Image<'pixels>>,
-    c_api_free: unsafe extern fn(*mut c_void),
+    c_api_free: unsafe extern "C" fn(*mut c_void),
 }
 
 #[repr(C)]
@@ -424,7 +424,7 @@ pub extern "C" fn liq_histogram_destroy(_hist: Option<Box<liq_histogram>>) {}
 #[no_mangle]
 #[inline(never)]
 #[deprecated(note = "custom allocators are no longer supported")]
-pub extern "C" fn liq_attr_create_with_allocator(_unused: *mut c_void, free: unsafe extern fn(*mut c_void)) -> Option<Box<liq_attr>> {
+pub extern "C" fn liq_attr_create_with_allocator(_unused: *mut c_void, free: unsafe extern "C" fn(*mut c_void)) -> Option<Box<liq_attr>> {
     let attr = Box::new(liq_attr {
         magic_header: LIQ_ATTR_MAGIC,
         inner: Attributes::new(),

src/capi.rs

@@ -56,6 +56,6 @@ pub unsafe fn liq_write_remapped_image_rows_impl(result: &mut QuantizationResult
 }
 
 /// Not recommended
-pub unsafe fn liq_image_set_memory_ownership_impl(image: &mut Image<'_>, own_rows: bool, own_pixels: bool, free_fn: unsafe extern fn(*mut std::os::raw::c_void)) -> Result<(), Error> {
+pub unsafe fn liq_image_set_memory_ownership_impl(image: &mut Image<'_>, own_rows: bool, own_pixels: bool, free_fn: unsafe extern "C" fn(*mut std::os::raw::c_void)) -> Result<(), Error> {
     image.px.set_memory_ownership(own_rows, own_pixels, free_fn)
 }

src/rows.rs

@@ -216,7 +216,7 @@ impl<'pixels, 'rows> DynamicRows<'pixels, 'rows> {
 
     /// Not recommended
     #[cfg(feature = "_internal_c_ffi")]
-    pub(crate) unsafe fn set_memory_ownership(&mut self, own_rows: bool, own_pixels: bool, free_fn: unsafe extern fn(*mut std::os::raw::c_void)) -> Result<(), Error> {
+    pub(crate) unsafe fn set_memory_ownership(&mut self, own_rows: bool, own_pixels: bool, free_fn: unsafe extern "C" fn(*mut std::os::raw::c_void)) -> Result<(), Error> {
         if own_rows {
             match &mut self.pixels {
                 PixelsSource::Pixels { rows, .. } => rows.make_owned(free_fn),

src/seacow.rs

@@ -44,7 +44,7 @@ impl<'a, T> SeaCow<'a, T> {
     #[inline]
     #[cfg(feature = "_internal_c_ffi")]
     #[must_use]
-    pub unsafe fn c_owned(ptr: *mut T, len: usize, free_fn: unsafe extern fn(*mut c_void)) -> Self {
+    pub unsafe fn c_owned(ptr: *mut T, len: usize, free_fn: unsafe extern "C" fn(*mut c_void)) -> Self {
         debug_assert!(!ptr.is_null());
         debug_assert!(len > 0);
 
@@ -55,7 +55,7 @@ impl<'a, T> SeaCow<'a, T> {
 
     #[inline]
     #[cfg(feature = "_internal_c_ffi")]
-    pub(crate) fn make_owned(&mut self, free_fn: unsafe extern fn(*mut c_void)) {
+    pub(crate) fn make_owned(&mut self, free_fn: unsafe extern "C" fn(*mut c_void)) {
         if let SeaCowInner::Borrowed(slice) = self.inner {
             self.inner = SeaCowInner::Owned { ptr: slice.as_ptr().cast_mut(), len: slice.len(), free_fn };
         }
@@ -80,7 +80,7 @@ impl<T: Clone> Clone for SeaCowInner<'_, T> {
 
 enum SeaCowInner<'a, T> {
     #[cfg(feature = "_internal_c_ffi")]
-    Owned { ptr: *mut T, len: usize, free_fn: unsafe extern fn(*mut c_void) },
+    Owned { ptr: *mut T, len: usize, free_fn: unsafe extern "C" fn(*mut c_void) },
     Borrowed(&'a [T]),
     Boxed(Box<[T]>),
 }