Skip to content

Commit 719564a

Browse files
committed
-> Don't hide the spinner until the page is really done loading
1 parent 1fc5312 commit 719564a

File tree

2 files changed

+11
-29
lines changed

2 files changed

+11
-29
lines changed

static/js/filterutils.js

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,6 @@ define(['jquery', 'base'], function($, base) {
196196
if (sliders.length > 0) {
197197
load_sliders(sliders, false);
198198
}
199-
200199
//mkFiltText();
201200
//return updateFacetsData(true).promise();
202201
return handleFilterSelectionUpdate(null, true, true)
@@ -633,7 +632,6 @@ define(['jquery', 'base'], function($, base) {
633632
}
634633
};
635634

636-
637635
window.resetFilters = function(){
638636
$('input:checkbox').not('.hide-zeros').not('.tbl-sel').prop('checked',false);
639637
$('input:checkbox').not('.hide-zeros').not('.tbl-sel').prop('indeterminate',false);
@@ -664,34 +662,22 @@ define(['jquery', 'base'], function($, base) {
664662
} else {
665663
first_filter_load = false;
666664
}
667-
}
665+
}
668666
}
669667

670668
if (doUpdate){
671669
var mxstudies = 0;
672670
var mxseries = 0;
673-
674671
var projArr=[];
675672
var serverdata = [updateFacetsData(true)];
676673
projArr = Object.keys(window.proj_in_cart);
677-
/*
678-
$('#projects_table').find('tr').each(function(){
679-
if ($(this).hasClass('someInCart')){
680-
var projid = $(this).attr('data-projectid');
681-
projArr.push(projid)
682-
}
683-
684-
});*/
685-
686-
if (projArr.length>0)
687-
{
674+
if (projArr.length>0) {
688675
serverdata.push(getProjectCartStats(projArr));
689676
}
690677

691678
$('.spinner').show();
692679
//$.when.apply(undefined, serverdata).then(function(ret)
693-
promise = Promise.all(serverdata).then(function(ret)
694-
{
680+
promise = Promise.all(serverdata).then(function(ret) {
695681

696682
var collFilt = ret[0][0];
697683
var collectionData = ret[0][1];
@@ -711,22 +697,18 @@ define(['jquery', 'base'], function($, base) {
711697
cartStats={}
712698
}
713699
//var numStudiesRet = totals.StudyInstanceUID;
714-
715-
716-
717700
createPlots('search_orig_set');
718-
createPlots('search_derived_set');
719-
createPlots('tcga_clinical');
701+
createPlots('search_derived_set');
702+
createPlots('tcga_clinical');
720703

721704
if ($('.search-configuration').find('.hide-zeros')[0].checked) {
722-
addSliders('search_orig_set', false, true, '');
723-
addSliders('quantitative', false, true, 'quantitative.');
724-
addSliders('tcga_clinical', false, true, 'tcga_clinical.');
725-
}
705+
addSliders('search_orig_set', false, true, '');
706+
addSliders('quantitative', false, true, 'quantitative.');
707+
addSliders('tcga_clinical', false, true, 'tcga_clinical.');
708+
}
726709

727710
updateTablesAfterFilter(collFilt, collectionData, collectionStats,cartStats);
728711
$('.spinner').hide();
729-
//updateTableCounts(1)
730712
});
731713

732714

static/js/image_search.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ require([
624624
}
625625
}
626626

627-
$(document).ready(function () {
627+
$(document).ready(async function () {
628628

629629
tables.initializeTableCacheData();
630630
tables.initializeTableViewedItemsData();
@@ -694,7 +694,7 @@ require([
694694
window.cartHist.push(cartSel);
695695
window.proj_in_cart = new Object();
696696

697-
filterutils.load_preset_filters();
697+
await filterutils.load_preset_filters();
698698
$('.hide-filter-uri').on('click',function() {
699699
$(this).hide();
700700
$('.get-filter-uri').show();

0 commit comments

Comments
 (0)