Ensure uid property of ROI is not undefined

Author: hackermd

src/roi.js

@@ -16,6 +16,9 @@ class ROI {
     if (!('uid' in options)) {
       this.uid = generateUuid();
     } else {
+      if (!(typeof options.uid === 'string' || options.uid instanceof String)) {
+        throw new Error('uid of ROI must be a string')
+      }
       this.uid = options.uid;
     }
     this.scoord3d = options.scoord3d;

test/api.spec.js

@@ -168,4 +168,15 @@ describe('dicomMicroscopyViewer.api.VLWholeSlideMicroscopyImageViewer', ()=> {
         assert.deepEqual(rois[0].scoord3d.coordinates, newPoint.coordinates);
     })
 
+    it('should throw an error if uid of ROI is undefined', () => {
+        assert.throws( function() {
+          const roid = new dicomMicroscopyViewer.roi.ROI({scoord3d : point, uid: undefined, properties})
+        }, Error )
+    })
+
+    it('should throw an error if uid of ROI is null', () => {
+        assert.throws( function() {
+          const roid = new dicomMicroscopyViewer.roi.ROI({scoord3d : point, uid: null, properties})
+        }, Error )
+    })
 });