making coordinates, majorAxisEndpointCoordinates, minorAxisEndpointCoordinates, centerCoordinates and radius private with Symbols

Author: biharck

src/scoord3d.js

@@ -2,30 +2,37 @@
  * Spatial coordinates of a geometric region of interest (ROI) in the DICOM
  * image coordinate system.
  */
+const _coordinates = Symbol('coordinates')
+const _majorAxisEndpointCoordinates = Symbol('majorAxisEndpointCoordinates')
+const _minorAxisEndpointCoordinates = Symbol('minorAxisEndpointCoordinates')
+const _centerCoordinates = Symbol('centerCoordinates')
+const _radius = Symbol('radius')
+
 class Scoord3D {
 
   constructor() {}
 
   get graphicData() {
-    throw new Error('Propotype property "graphicData" must be implemented.');
+    throw new Error('Propotype property "graphicData" must be implemented.')
   }
 
   get graphicType() {
-    throw new Error('Propotype property "graphicType" must be implemented.');
+    throw new Error('Propotype property "graphicType" must be implemented.')
   }
 
   get referencedFrameOfReferenceUID() {
-    throw new Error('Propotype property "referencedFrameOfReferenceUID" must be implemented.');
+    throw new Error('Propotype property "referencedFrameOfReferenceUID" must be implemented.')
   }
 
   get fiducialUID() {
-    throw new Error('Propotype property "fiducialUID" must be implemented.');
+    throw new Error('Propotype property "fiducialUID" must be implemented.')
   }
 
 }
 
 class Point extends Scoord3D {
-
+  
+  
   constructor(coordinates) {
     super()
     if (!Array.isArray(coordinates)) {
@@ -34,15 +41,15 @@ class Point extends Scoord3D {
     if (coordinates.length !== 3) {
       throw new Error('coordinates of Point must be an array of length 3')
     }
-    this.coordinates = coordinates;
+    this[_coordinates] = coordinates
   }
 
   get graphicData() {
-    return this.coordinates;
+    return this[_coordinates]
   }
 
   get graphicType() {
-    return 'POINT';
+    return 'POINT'
   }
 
 }
@@ -57,15 +64,15 @@ class Multipoint extends Scoord3D {
     if(coordinates.find(c => c.length !== 3)!== undefined){
       throw new Error('coordinates of Multipoint must be an array of length 3')
     }
-    this.coordinates = coordinates
+    this[_coordinates] = coordinates
   }
 
   get graphicData() {
-    return this.coordinates;
+    return this[_coordinates]
   }
 
   get graphicType() {
-    return 'MULTIPOINT';
+    return 'MULTIPOINT'
   }
 
 }
@@ -80,7 +87,7 @@ class Polyline extends Scoord3D {
     if(coordinates.find(c => c.length !== 3)!== undefined){
       throw new Error('coordinates of Polyline must be a list of points of length 3')
     }
-    this.coordinates = coordinates
+    this[_coordinates] = coordinates
   }
 
   get graphicData() {
@@ -89,11 +96,11 @@ class Polyline extends Scoord3D {
      * with ordered vertices denoted by (column,row) pairs.
      * If the first and last vertices are the same it is a closed polygon.
      */
-    return this.coordinates;
+    return this[_coordinates]
   }
 
   get graphicType() {
-    return 'POLYLINE';
+    return 'POLYLINE'
   }
 
 }
@@ -108,20 +115,20 @@ class Polygon extends Scoord3D {
     if(coordinates.find(c => c.length !== 3)!== undefined){
       throw new Error('coordinates of Polygon must be a list of points of length 3')
     }
-    this.coordinates = coordinates
+    this[_coordinates] = coordinates
   }
 
   get graphicData() {
     /*
      * A polygon is defined a series of connected line segments with ordered vertices 
      * denoted by (x,y,z) triplets, where the first and last vertices shall be the same 
-     * forming a polygon; the points shall be coplanar
+     * forming a polygon the points shall be coplanar
      */
-    return this.coordinates;
+    return this[_coordinates]
   }
 
   get graphicType() {
-    return 'POLYGON';
+    return 'POLYGON'
   }
 
 }
@@ -139,8 +146,8 @@ class Circle extends Scoord3D {
     if (radius === undefined) {
       throw new Error('radius has to be defined')
     }
-    this.centerCoordinates = centerCoordinates
-    this.radius = radius
+    this[_centerCoordinates] = centerCoordinates
+    this[_radius] = radius
   }
 
   get graphicData() {
@@ -150,12 +157,12 @@ class Circle extends Scoord3D {
      * The second point is a pixel on the perimeter of the circle.
      */
     return [
-      this.centerCoordinates,
-      [this.centerCoordinates[0], this.centerCoordinates[1] + this.radius, 1]];
+      this[_centerCoordinates],
+      [this[_centerCoordinates[0]], this[_centerCoordinates[1]] + this[_radius], 1]]
   }
 
   get graphicType() {
-    return 'CIRCLE';
+    return 'CIRCLE'
   }
 
 }
@@ -176,8 +183,8 @@ class Ellipse extends Scoord3D {
     if (minorAxisEndpointCoordinates.length !== 2) {
       throw new Error('minorAxisEndpointCoordinates coordinates of Ellipse must be an array of length 2')
     }
-    this.majorAxisEndpointCoordinates = majorAxisEndpointCoordinates
-    this.minorAxisEndpointCoordinates = minorAxisEndpointCoordinates
+    this[_majorAxisEndpointCoordinates] = majorAxisEndpointCoordinates
+    this[_minorAxisEndpointCoordinates] = minorAxisEndpointCoordinates
   }
 
   get graphicData() {
@@ -187,16 +194,16 @@ class Ellipse extends Scoord3D {
      * The second two points specify the endpoints of the minor axis.
      */
     return [
-      ...this.majorAxisEndpointCoordinates,
-      ...this.minorAxisEndpointCoordinates
-    ];
+      ...this[_majorAxisEndpointCoordinates],
+      ...this[_minorAxisEndpointCoordinates]
+    ]
   }
 
   get graphicType() {
-    return 'ELLIPSE';
+    return 'ELLIPSE'
   }
 
 }
 
-export { Point, Multipoint, Polyline, Polygon, Circle, Ellipse };
+export { Point, Multipoint, Polyline, Polygon, Circle, Ellipse }