Skip to content

Commit 2ac8e62

Browse files
committed
ENH: Support compatibility with pydicom 3 and newer
1 parent 91f3c3d commit 2ac8e62

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ dependencies = [
3232
"requests>=2.18",
3333
"retrying>=1.3.3",
3434
"Pillow>=8.3",
35-
"pydicom>=2.2",
35+
"pydicom>=3.0.0",
3636
"typing-extensions>=4.0; python_version < '3.8.0'",
3737
]
3838

src/dicomweb_client/file.py

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,7 @@
3232
from pydicom.datadict import dictionary_VR, keyword_for_tag, tag_for_keyword
3333
from pydicom.dataelem import DataElement
3434
from pydicom.dataset import Dataset, FileMetaDataset
35-
from pydicom.encaps import encapsulate
36-
try:
37-
# pydicom >= 3.0 - parse_basic_offsets replaces get_frame_offsets
38-
from pydicom.encaps import parse_basic_offsets
39-
_use_parse_basic_offsets = True
40-
except ImportError:
41-
# pydicom < 3.0 - use deprecated get_frame_offsets
42-
from pydicom.encaps import get_frame_offsets
43-
_use_parse_basic_offsets = False
35+
from pydicom.encaps import encapsulate, parse_basic_offsets
4436
from pydicom.errors import InvalidDicomError
4537
from pydicom.filebase import DicomFileLike
4638
from pydicom.filereader import data_element_offset_to_value, dcmread
@@ -359,11 +351,7 @@ def _read_bot(fp: DicomFileLike) -> np.ndarray:
359351
)
360352
fp.seek(pixel_data_element_value_offset - 4, 1)
361353

362-
# Use parse_basic_offsets for pydicom >= 3.0, get_frame_offsets for < 3.0
363-
if _use_parse_basic_offsets:
364-
offsets = parse_basic_offsets(fp)
365-
else:
366-
is_empty, offsets = get_frame_offsets(fp)
354+
offsets = parse_basic_offsets(fp)
367355

368356
return np.array(offsets, dtype=np.uint32)
369357

0 commit comments

Comments
 (0)