Fix unit test case for python 2.7

hackermd · hackermd · commit 45e0b204a5ad · 2018-11-27T19:57:38.000-05:00
diff --git a/src/dicomweb_client/tests/test_api.py b/src/dicomweb_client/tests/test_api.py
@@ -345,7 +345,8 @@ def test_load_json_dataset_pn_vm1_empty(httpserver, client, cache_dir):
         },
     }
     dataset = load_json_dataset(dicom_json)
-    assert dataset.ReferringPhysicianName == ''
+    # This returns different results for Python2 (None) and Python3 ("")
+    assert dataset.ReferringPhysicianName in (None, '')
 
 
 def test_load_json_dataset_pn_vm2_empty(httpserver, client, cache_dir):

Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,8 @@ def test_load_json_dataset_pn_vm1_empty(httpserver, client, cache_dir):`
`345`	`345`	`},`
`346`	`346`	`}`
`347`	`347`	`dataset = load_json_dataset(dicom_json)`
`348`		`- assert dataset.ReferringPhysicianName == ''`
	`348`	`+ # This returns different results for Python2 (None) and Python3 ("")`
	`349`	`+ assert dataset.ReferringPhysicianName in (None, '')`
`349`	`350`
`350`	`351`
`351`	`352`	`def test_load_json_dataset_pn_vm2_empty(httpserver, client, cache_dir):`