Skip to content

ENH: Replace pydicom deprecated usage of get_frame_offsets #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ENH: Replace pydicom deprecated usage of get_frame_offsets #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91f3c3d
ENH: Replace pydicom deprecated usage of get_frame_offsets
jamesobutler Nov 13, 2025
b4af343
ENH: Support compatibility with pydicom 3 and newer
jamesobutler Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ dependencies = [
"requests>=2.18",
"retrying>=1.3.3",
"Pillow>=8.3",
"pydicom>=2.2",
"pydicom>=3.0.0",
"typing-extensions>=4.0; python_version < '3.8.0'",
]

Expand Down
4 changes: 2 additions & 2 deletions src/dicomweb_client/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
from pydicom.datadict import dictionary_VR, keyword_for_tag, tag_for_keyword
from pydicom.dataelem import DataElement
from pydicom.dataset import Dataset, FileMetaDataset
from pydicom.encaps import encapsulate, get_frame_offsets
from pydicom.encaps import encapsulate, parse_basic_offsets
from pydicom.errors import InvalidDicomError
from pydicom.filebase import DicomFileLike
from pydicom.filereader import data_element_offset_to_value, dcmread
Expand Down Expand Up @@ -350,7 +350,7 @@ def _read_bot(fp: DicomFileLike) -> np.ndarray:
fp.is_implicit_VR, 'OB'
)
fp.seek(pixel_data_element_value_offset - 4, 1)
is_empty, offsets = get_frame_offsets(fp)
offsets = parse_basic_offsets(fp)
return np.array(offsets, dtype=np.uint32)


Expand Down
Loading