Skip to content

ENH: Specify explicit support for Python 3.14 #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2025
Merged

ENH: Specify explicit support for Python 3.14 #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6edcadd
ENH: Update Logging filter type
jamesobutler Nov 13, 2025
bd5ad5d
BUG: Fix unreachable code
jamesobutler Nov 13, 2025
9020611
ENH: Bump mypy to latest version
jamesobutler Nov 13, 2025
5076ef5
ENH: Bump pytest to latest version
jamesobutler Nov 13, 2025
f695f5f
ENH: Specify explicit support for Python 3.14
jamesobutler Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/run_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ jobs:
"3.10",
"3.11",
"3.12",
"3.13"
"3.13",
"3.14"
]

steps:
Expand Down
7 changes: 4 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ classifiers = [
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
]
dependencies = [
"numpy>=1.19",
Expand All @@ -41,10 +42,10 @@ gcp = ["dataclasses>=0.8; python_version=='3.6'", "google-auth>=1.6"]

[dependency-groups]
test = [
"mypy==0.982",
"mypy==1.18.2",
"flake8==6.1.0",
"pytest==7.1.3",
"pytest-cov==3.0.0",
"pytest==9.0.1",
"pytest-cov==7.0.0",
"pytest-flake8==1.1.3",
"pytest-localserver==0.5.0",
"types-requests==2.27.14",
Expand Down
2 changes: 1 addition & 1 deletion src/dicomweb_client/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ class _QueryResourceType(Enum):


def _build_acceptable_media_type_lut(
media_types: Tuple[Union[str, Tuple[str, str]], ...],
media_types: Tuple[Union[str, Tuple[str, ...]], ...],
supported_media_type_lut: Mapping[str, Iterable[str]]
) -> Mapping[str, Iterable[str]]:
# If no acceptable transfer syntax has been specified, then we just return
Expand Down
10 changes: 5 additions & 5 deletions src/dicomweb_client/log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import logging


def _filter_header_parsing_error(record: logging.LogRecord) -> int:
def _filter_header_parsing_error(record: logging.LogRecord) -> bool:
"""Filters warnings of ``urllib3.exceptions.HeaderParsingError``.

Parameters
Expand All @@ -13,13 +13,13 @@ def _filter_header_parsing_error(record: logging.LogRecord) -> int:

Returns
-------
int
zero if the record should be filtered, non-zero otherwise
bool
False if the record should be filtered, True otherwise

"""
if 'Failed to parse headers' in record.getMessage():
return 0
return 1
return False
return True


def _map_logging_verbosity(verbosity: int) -> int:
Expand Down