Add Meziantou.Analyzers (#160)

Author: viceroypenguin

.editorconfig

@@ -306,3 +306,13 @@ dotnet_diagnostic.CA2000.severity = error               # CA2000: Dispose object
 dotnet_diagnostic.CA1515.severity = none                # CA1515: Consider making public types internal
 dotnet_diagnostic.CA1708.severity = none                # CA1708: Identifiers should differ by more than case
 dotnet_diagnostic.CA1716.severity = none                # CA1716: Identifiers should not match keywords
+
+MA0053.public_class_should_be_sealed = true
+MA0053.exceptions_should_be_sealed = true
+
+dotnet_diagnostic.MA0004.severity = none
+dotnet_diagnostic.MA0023.severity = none
+dotnet_diagnostic.MA0048.severity = none
+dotnet_diagnostic.MA0051.severity = none
+dotnet_diagnostic.MA0053.severity = warning
+dotnet_diagnostic.MA0071.severity = none

Directory.Packages.props

@@ -34,4 +34,8 @@
 	<PackageVersion Include="Verify.TUnit" Version="28.9.0" />
 	<PackageVersion Include="xunit.v3.assert" Version="1.0.1" />
   </ItemGroup>
+
+  <ItemGroup>
+	<GlobalPackageReference Include="Meziantou.Analyzer" Version="2.0.186" />
+  </ItemGroup>
 </Project>

src/Common/ITypeSymbolExtensions.cs

@@ -53,21 +53,15 @@ public static IEnumerable<ITypeSymbol> GetBaseTypesAndThis(this ITypeSymbol? typ
 		}
 	}
 
-	public static IEnumerable<ISymbol> GetAllMembers(this ITypeSymbol type)
-	{
-		if (type is { TypeKind: TypeKind.Interface })
-		{
-			return type.AllInterfaces
+	public static IEnumerable<ISymbol> GetAllMembers(this ITypeSymbol type) =>
+		type is { TypeKind: TypeKind.Interface }
+			? type
+				.AllInterfaces
 				.SelectMany(i => i.GetMembers())
-				.Concat(type.GetMembers());
-		}
-		else
-		{
-			return type
+				.Concat(type.GetMembers())
+			: type
 				.GetBaseTypesAndThis()
 				.SelectMany(t => t.GetMembers());
-		}
-	}
 
 	public static bool IsValidateAttribute([NotNullWhen(returnValue: true)] this INamedTypeSymbol? typeSymbol) =>
 		typeSymbol is

src/Immediate.Validations.Analyzers/UnusedConstructorParameterSuppressor.cs

@@ -36,7 +36,8 @@ public override void ReportSuppressions(SuppressionAnalysisContext context)
 
 			if (symbol.BaseType.IsValidatorAttribute())
 			{
-				var suppression = SupportedSuppressions.First(s => s.SuppressedDiagnosticId == diagnostic.Id);
+				var suppression = SupportedSuppressions
+					.First(s => string.Equals(s.SuppressedDiagnosticId, diagnostic.Id, StringComparison.Ordinal));
 
 				context.ReportSuppression(
 					Suppression.Create(

src/Immediate.Validations.Analyzers/ValidateClassAnalyzer.cs

@@ -352,7 +352,9 @@ ITypeSymbol typeArgumentType
 					attributeProperties ??= attribute.AttributeClass!.GetMembers()
 						.OfType<IPropertySymbol>()
 						.ToList();
-					var property = attributeProperties.First(a => a.Name == name);
+
+					var property = attributeProperties
+						.First(a => string.Equals(a.Name, name, StringComparison.Ordinal));
 
 					ValidateArgument(
 						context,
@@ -370,7 +372,7 @@ ITypeSymbol typeArgumentType
 				{
 					for (var j = 0; j < attributeParameters.Length; j++)
 					{
-						if (attributeParameters[j].Name == name)
+						if (string.Equals(attributeParameters[j].Name, name, StringComparison.Ordinal))
 						{
 							ValidateArgument(
 								context,
@@ -422,12 +424,13 @@ List<ISymbol> members
 		if (!parameter.IsTargetTypeSymbol())
 			return;
 
-		var validateParameter = validateParameterSymbols.First(p => p.Name == parameter.Name);
+		var validateParameter = validateParameterSymbols
+			.First(p => string.Equals(p.Name, parameter.Name, StringComparison.Ordinal));
 
 		if (syntax.Expression.IsNameOfExpression(out var propertyName))
 		{
 			var member = members
-				.FirstOrDefault(p => p.Name == propertyName);
+				.Find(p => string.Equals(p.Name, propertyName, StringComparison.Ordinal));
 
 			if (member is null)
 			{

src/Immediate.Validations.Analyzers/ValidatorClassAnalyzer.cs

@@ -283,8 +283,7 @@ IMethodSymbol methodSymbol
 			.GetMembers()
 			.OfType<IPropertySymbol>()
 			.Where(p =>
-				p.Name != "Message"
-				&& !p.IsStatic
+				p is { Name: not "Message", IsStatic: false }
 			)
 			.Cast<ISymbol>()
 			.ToList();

src/Immediate.Validations.CodeFixes/AddAdditionalValidationsCodeRefactoringProvider.cs

@@ -9,7 +9,7 @@
 namespace Immediate.Validations.CodeFixes;
 
 [ExportCodeRefactoringProvider(LanguageNames.CSharp, Name = "Add AdditionalValidations Method")]
-public class AddAdditionalValidationsCodeRefactoringProvider : CodeRefactoringProvider
+public sealed class AddAdditionalValidationsCodeRefactoringProvider : CodeRefactoringProvider
 {
 	public override async Task ComputeRefactoringsAsync(CodeRefactoringContext context)
 	{

src/Immediate.Validations.CodeFixes/AddValidateMethodCodefixProvider.cs

@@ -11,7 +11,7 @@
 namespace Immediate.Validations.CodeFixes;
 
 [ExportCodeFixProvider(LanguageNames.CSharp)]
-public class AddValidateMethodCodefixProvider : CodeFixProvider
+public sealed class AddValidateMethodCodefixProvider : CodeFixProvider
 {
 	public sealed override ImmutableArray<string> FixableDiagnosticIds { get; } =
 		ImmutableArray.Create([DiagnosticIds.IV0001ValidateMethodMustExist]);

src/Immediate.Validations.CodeFixes/CorrectValidatePropertyReturnTypeCodefixProvider.cs

@@ -10,7 +10,7 @@
 namespace Immediate.Validations.CodeFixes;
 
 [ExportCodeFixProvider(LanguageNames.CSharp)]
-public class CorrectValidatePropertyReturnTypeCodefixProvider : CodeFixProvider
+public sealed class CorrectValidatePropertyReturnTypeCodefixProvider : CodeFixProvider
 {
 	public sealed override ImmutableArray<string> FixableDiagnosticIds { get; } =
 		ImmutableArray.Create([DiagnosticIds.IV0004ValidateMethodMustReturnValueTuple]);

src/Immediate.Validations.CodeFixes/MakeValidatePropertyMethodStaticCodefixProvider.cs

@@ -9,7 +9,7 @@
 namespace Immediate.Validations.CodeFixes;
 
 [ExportCodeFixProvider(LanguageNames.CSharp)]
-public class MakeValidatePropertyMethodStaticCodefixProvider : CodeFixProvider
+public sealed class MakeValidatePropertyMethodStaticCodefixProvider : CodeFixProvider
 {
 	public sealed override ImmutableArray<string> FixableDiagnosticIds { get; } =
 		ImmutableArray.Create([DiagnosticIds.IV0002ValidateMethodMustBeStatic]);