-
Notifications
You must be signed in to change notification settings - Fork 10
Closed
Description
We have a lot of functions with the abbreviated calc_ naming style and then others with the full calculate_. We should be consistent and have a mild preference for the longer form, so we should update this lot:
We have quite a few abbreviated forms:
16 results - 4 files pyrealm/core/hygro.py: 16 17: def calc_vp_sat( 18 ta: NDArray[np.floating], core_const: CoreConst = CoreConst() 202 203: def calc_saturation_vapour_pressure_slope( 204 tc: NDArray[np.floating], 226 227: def calc_enthalpy_vaporisation(tc: NDArray[np.floating]) -> NDArray[np.floating]: 228 """Calculate the enthalpy of vaporization. 243 244: def calc_specific_heat(tc: NDArray[np.floating]) -> NDArray[np.floating]: 245 """Calculate the specific heat of air. 275 276: def calc_psychrometric_constant( 277 tc: NDArray[np.floating], pyrealm/core/pressure.py: 10 11: def calc_patm( 12 elv: NDArray[np.floating], core_const: CoreConst = CoreConst() pyrealm/pmodel/functions.py: 158 159: def calc_ftemp_inst_rd( 160 tc: NDArray[np.floating], 198 199: def calc_gammastar( 200 tk: NDArray[np.floating], 255 256: def calc_ns_star( 257 tk: NDArray[np.floating], 298 299: def calc_kmm( 300 tk: NDArray[np.floating], 368 369: def calc_soilmstress_stocker( 370 soilm: NDArray[np.floating], 480 481: def calc_soilmstress_mengoli( 482 soilm: NDArray[np.floating] = np.array(1.0), 579 580: def calc_co2_to_ca( 581 co2: NDArray[np.floating], patm: NDArray[np.floating] pyrealm/pmodel/isotopes.py: 102 103: def calc_c4_discrimination(self, pmodel: PModel) -> None: 104 r"""Calculate C4 isotopic discrimination. 139 140: def calc_c4_discrimination_vonC(self, pmodel: PModel) -> None: 141 r"""Calculate C4 isotopic discrimination. 193 194: def calc_c3_discrimination(self, pmodel: PModel) -> None: 195 r"""Calculate C3 isotopic discrimination.I think we should change them, but perhaps not in this PR?
Originally posted by @davidorme in #575
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done