Handle null server on dummy CommandSourceStacks for command sending checks

Questionable decision by vanilla to violate the nullability contracts when it seems they could just use server & overworld spawn like console does, but oh well...

Author: jpenilla

cloud-fabric/build.gradle.kts

@@ -29,7 +29,12 @@ configurations {
 
 dependencies {
     minecraft(libs.minecraft)
-    mappings(loom.officialMojangMappings())
+    mappings(
+        loom.layered {
+            officialMojangMappings()
+            parchment(property("neoForge.parchment.parchmentArtifact"))
+        }
+    )
     modImplementation(libs.fabricLoader)
 
     api(platform(libs.cloud.bom))

cloud-fabric/common-repack/build.gradle.kts

@@ -7,7 +7,12 @@ plugins {
 
 dependencies {
     minecraft(libs.minecraft)
-    mappings(loom.officialMojangMappings())
+    mappings(
+        loom.layered {
+            officialMojangMappings()
+            parchment(property("neoForge.parchment.parchmentArtifact"))
+        }
+    )
     compileOnly(libs.fabricLoader)
 }
 

cloud-fabric/src/main/java/org/incendo/cloud/fabric/FabricServerCommandManager.java

@@ -117,6 +117,14 @@ public boolean hasPermission(final @NonNull C sender, final @NonNull String perm
             return true;
         }
         final CommandSourceStack source = this.senderMapper().reverse(sender);
+
+        // noinspection ConstantConditions - vanilla annotations are lying
+        if (source.getServer() == null) {
+            // Handle 1.21.11 quirk, this is a best effort impl. for 'restricted' checking...
+            // If necessary we could use Mixin to allow explicitly setting the flag.
+            return false; // Permission is implicitly not empty
+        }
+
         if (HAS_PERMISSIONS_API) {
             return Permissions.check(source, permission, source.getServer().operatorUserPermissions().level());
         }

cloud-neoforge/src/main/java/org/incendo/cloud/neoforge/NeoForgeServerCommandManager.java

@@ -112,6 +112,14 @@ public boolean hasPermission(final @NonNull C sender, final @NonNull String perm
             }
             return PermissionAPI.getPermission(source.getPlayer(), node);
         }
+
+        // noinspection ConstantConditions - vanilla annotations are lying
+        if (source.getServer() == null) {
+            // Handle 1.21.11 quirk, this is a best effort impl. for 'restricted' checking...
+            // If necessary we could use Mixin to allow explicitly setting the flag.
+            return false; // Permission is implicitly not empty
+        }
+
         return source.permissions().hasPermission(
             new Permission.HasCommandLevel(source.getServer().operatorUserPermissions().level())
         );

gradle.properties

@@ -2,6 +2,8 @@ group=org.incendo
 version=2.0.0-SNAPSHOT
 description=Cloud implementations for modded Minecraft
 
+neoForge.parchment.parchmentArtifact=io.papermc.parchment.data:parchment:1.21.11+build.2
+
 org.gradle.caching=true
 org.gradle.configuration-cache=true
 org.gradle.parallel=true

settings.gradle.kts

@@ -34,7 +34,7 @@ dependencyResolutionManagement {
 
     versionCatalogs {
         create("fabricApiLibs") {
-            from("net.fabricmc.fabric-api:fabric-api-catalog:0.134.0+1.21.9")
+            from("net.fabricmc.fabric-api:fabric-api-catalog:0.139.4+1.21.11")
         }
     }
 }