fix(MorphoLeverageStrategyExtension): use .call instead of .transfer when withdrawingEther to remove gas limitation (#193)

ckoopmann · web-flow · commit 67b744554b59 · 2024-11-11T16:25:16.000+01:00
diff --git a/contracts/adapters/MorphoLeverageStrategyExtension.sol b/contracts/adapters/MorphoLeverageStrategyExtension.sol
@@ -615,7 +615,8 @@ contract MorphoLeverageStrategyExtension is BaseExtension {
      * OPERATOR ONLY: Withdraw entire balance of ETH in this contract to operator. Rebalance must not be in progress
      */
     function withdrawEtherBalance() external onlyOperator noRebalanceInProgress {
-        msg.sender.transfer(address(this).balance);
+        (bool success, ) = msg.sender.call{value: address(this).balance}("");
+        require(success, "Ether transfer failed");
     }
 
     receive() external payable {}

Original file line number	Diff line number	Diff line change
`@@ -615,7 +615,8 @@ contract MorphoLeverageStrategyExtension is BaseExtension {`
`615`	`615`	`* OPERATOR ONLY: Withdraw entire balance of ETH in this contract to operator. Rebalance must not be in progress`
`616`	`616`	`*/`
`617`	`617`	`function withdrawEtherBalance() external onlyOperator noRebalanceInProgress {`
`618`		`- msg.sender.transfer(address(this).balance);`
	`618`	`+ (bool success, ) = msg.sender.call{value: address(this).balance}("");`
	`619`	`+ require(success, "Ether transfer failed");`
`619`	`620`	`}`
`620`	`621`
`621`	`622`	`receive() external payable {}`