fix: Sync aave leverage module upon leveraged issuance / redemption (#99)

* Sync aave leverage module from inside the contract

* Add IAaveLeverageModule interface

* Parameterize integration test to be run both for Eth2x and iEth

* Change calculation of eth to spend per test case

* Reduce min amount out in test

Co-authored-by: Christian Koopmann <[email protected]>

Author: ckoopmann

contracts/exchangeIssuance/ExchangeIssuanceLeveraged.sol

@@ -26,6 +26,7 @@ import { ReentrancyGuard } from "@openzeppelin/contracts/utils/ReentrancyGuard.s
 
 import { ISwapRouter} from "../interfaces/external/ISwapRouter.sol";
 import { IAToken } from "../interfaces/IAToken.sol";
+import { IAaveLeverageModule } from "../interfaces/IAaveLeverageModule.sol";
 import { IDebtIssuanceModule } from "../interfaces/IDebtIssuanceModule.sol";
 import { IController } from "../interfaces/IController.sol";
 import { ISetToken } from "../interfaces/ISetToken.sol";
@@ -93,6 +94,7 @@ contract ExchangeIssuanceLeveraged is ReentrancyGuard, FlashLoanReceiverBaseV2,
     address immutable public WETH;
     IController public immutable setController;
     IDebtIssuanceModule public immutable debtIssuanceModule;
+    IAaveLeverageModule public immutable aaveLeverageModule;
 
     /* ============ Events ============ */
 
@@ -135,6 +137,7 @@ contract ExchangeIssuanceLeveraged is ReentrancyGuard, FlashLoanReceiverBaseV2,
     * @param _uniV3Router           Address of uniswap v3 router
     * @param _setController         SetToken controller used to verify a given token is a set
     * @param _debtIssuanceModule    DebtIssuanceModule used to issue and redeem tokens
+    * @param _aaveLeverageModule    AaveLeverageModule to sync before every issuance / redemption
     * @param _addressProvider       Address of DebtIssuanceModule used to issue and redeem tokens
     */
     constructor(
@@ -144,6 +147,7 @@ contract ExchangeIssuanceLeveraged is ReentrancyGuard, FlashLoanReceiverBaseV2,
         ISwapRouter _uniV3Router,
         IController _setController,
         IDebtIssuanceModule _debtIssuanceModule,
+        IAaveLeverageModule _aaveLeverageModule,
         address _addressProvider
     )
         public
@@ -152,6 +156,7 @@ contract ExchangeIssuanceLeveraged is ReentrancyGuard, FlashLoanReceiverBaseV2,
     {
         setController = _setController;
         debtIssuanceModule = _debtIssuanceModule;
+        aaveLeverageModule = _aaveLeverageModule;
 
         WETH = _weth;
     }
@@ -571,6 +576,7 @@ contract ExchangeIssuanceLeveraged is ReentrancyGuard, FlashLoanReceiverBaseV2,
         isSetToken(_setToken)
         internal
     {
+        aaveLeverageModule.sync(_setToken);
         LeveragedTokenData memory leveragedTokenData = _getLeveragedTokenData(_setToken, _setAmount, true);
 
         address[] memory assets = new address[](1);
@@ -620,6 +626,7 @@ contract ExchangeIssuanceLeveraged is ReentrancyGuard, FlashLoanReceiverBaseV2,
         isSetToken(_setToken)
         internal
     {
+        aaveLeverageModule.sync(_setToken);
         LeveragedTokenData memory leveragedTokenData = _getLeveragedTokenData(_setToken, _setAmount, false);
 
         address[] memory assets = new address[](1);

contracts/interfaces/IAaveLeverageModule.sol

@@ -0,0 +1,23 @@
+/*
+    Copyright 2021 Set Labs Inc.
+
+    Licensed under the Apache License, Version 2.0 (the "License");
+    you may not use this file except in compliance with the License.
+    You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+
+    SPDX-License-Identifier: Apache License, Version 2.0
+*/
+pragma solidity 0.6.10;
+import { ISetToken } from "./ISetToken.sol";
+
+interface IAaveLeverageModule {
+    function sync(ISetToken _setToken) external virtual;
+}

test/exchangeIssuance/exchangeIssuanceLeveraged.spec.ts

@@ -381,6 +381,7 @@ describe("ExchangeIssuanceLeveraged", async () => {
         uniswapV3RouterAddress,
         controllerAddress,
         debtIssuanceModuleAddress,
+        aaveLeverageModule.address,
         addressProviderAddress,
       );
       return result;
@@ -433,6 +434,7 @@ describe("ExchangeIssuanceLeveraged", async () => {
         uniswapV3RouterAddress,
         controllerAddress,
         debtIssuanceModuleAddress,
+        aaveLeverageModule.address,
         addressProviderAddress,
       );
       ethAddress = await exchangeIssuance.ETH_ADDRESS();