Fix Codacy static code issue

Author: NamamiShanker

src/arguments/search.py

@@ -6,6 +6,7 @@
 
 from .error import SearchError
 from .utility import Utility
+from .utility import Playbook
 from .save import SaveSearchResults
 from .update import UpdateApplication
 from .api_test import ApiTesting
@@ -30,14 +31,15 @@ def __init__(self, arguments):
         self.arguments = arguments
         self.utility_object = Utility()
         self.api_test_object = ApiTesting()
+        self.playbook_object = Playbook()
 
     def search_args(self):
         if self.arguments.search:
             self.search_for_results()
         elif self.arguments.file:
             self.search_for_results(True)
         elif self.arguments.playbook:
-            self.utility_object.display_playbook()
+            self.playbook_object.display_panel()
         elif self.arguments.new:
             url = "https://stackoverflow.com/questions/ask"
             if type(self.arguments.new) == str:

src/arguments/utility.py

@@ -68,7 +68,7 @@ def playbook_content(self):
     def playbook_content(self, value):
         """
         Saves playbook in the following format
-        {   
+        {
             time_of_update: unix,
             items_stackoverflow:
             [
@@ -83,10 +83,9 @@ def playbook_content(self, value):
             ]
         }
         """
-        if type(value) == dict:
+        if isinstance(value, dict):
             with open(self.playbook_path, 'w') as playbook:
                 json.dump(value, playbook, ensure_ascii=False)
-            pass
         else:
             raise ValueError("value should be of type dict")
 
@@ -96,10 +95,10 @@ def is_question_in_playbook(self, question_id):
             if int(entry['question_id']) == int(question_id):
                 return True
         return False
-    
+
     def add_to_playbook(self, stackoverflow_object, question_id):
         """
-        Receives a QuestionsPanelStackoverflow object and 
+        Receives a QuestionsPanelStackoverflow object and
         saves data of a particular question into playbook
         """
         if self.is_question_in_playbook(question_id):
@@ -136,11 +135,12 @@ def display_panel(self):
         if(len(playbook_data['items_stackoverflow']) == 0):
             SearchError("You have no entries in the playbook", "Browse and save entries in playbook with 'p' key")
             sys.exit()
+        # Creates QuestionPanelStackoverflow object, populates its question_data and answer_data and displays it
         question_panel = QuestionsPanelStackoverflow()
         for item in playbook_data['items_stackoverflow']:
             question_panel.questions_data.append( [item['question_title'], item['question_id'], item['question_link']] )
             question_panel.answer_data[item['question_id']] = item['answer_body']
-        question_panel.display_panel(playbook=True)
+        question_panel.display_panel([], playbook=True)
 
 class QuestionsPanelStackoverflow():
     def __init__(self):
@@ -235,8 +235,8 @@ def navigate_questions_panel(self, playbook=False):
                 elif(question_menu.chosen_accept_key == 'd' and playbook):
                     self.playbook.delete_from_playbook(self, self.questions_data[options_index][1])
 
-    def display_panel(self, questions_list=[], playbook=False):
-        if len(questions_list) != 0:
+    def display_panel(self, questions_list, playbook=False):
+        if not playbook:
             self.populate_question_data(questions_list)
             self.populate_answer_data(questions_list)
         self.navigate_questions_panel(playbook=playbook)
@@ -309,10 +309,6 @@ def get_ans(self, questions_list):
         stackoverflow_panel.display_panel(questions_list)
         # Support for reddit searching can also be implemented from here
 
-    def display_playbook(self):
-        playbook = Playbook()
-        playbook.display_panel()
-
     # Get an access token and extract to a JSON file "access_token.json"
     @classmethod
     def setCustomKey(self):