Skip to content

Commit ddc70ae

Browse files
davidchaikeniancojamshale
authored
feat(demo): remove broken aip 10 and fix aip 20 (openwallet-foundation#3611)
* demo: fix connectionless proof Signed-off-by: David Chaiken <[email protected]> * demo: send correct endpoint for connectionless proof requests Signed-off-by: David Chaiken <[email protected]> * feat(demo): update documentation removing aip 10 Signed-off-by: David Chaiken <[email protected]> --------- Signed-off-by: David Chaiken <[email protected]> Co-authored-by: Ian Costanzo <[email protected]> Co-authored-by: jamshale <[email protected]>
1 parent 96ea8e0 commit ddc70ae

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

demo/runners/support/agent.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1004,17 +1004,17 @@ async def service_decorator(self):
10041004
decorator = {
10051005
"recipientKeys": [agent_public_did["result"]["verkey"]],
10061006
# "routingKeys": [agent_public_did["result"]["verkey"]],
1007-
"serviceEndpoint": agent_endpoint["endpoint"],
1007+
"serviceEndpoint": agent_endpoint["endpoint"] or self.endpoint,
10081008
}
10091009
return decorator
10101010

10111011
async def _send_connectionless_proof_req(self, request: ClientRequest):
10121012
pres_req_id = request.match_info["pres_req_id"]
1013-
url = "/present-proof/records/" + pres_req_id
1013+
url = "/present-proof-2.0/records/" + pres_req_id
10141014
proof_exch = await self.admin_GET(url)
10151015
if not proof_exch:
10161016
return web.Response(status=404)
1017-
proof_reg_txn = proof_exch["presentation_request_dict"]
1017+
proof_reg_txn = proof_exch["pres_request"]
10181018
proof_reg_txn["~service"] = await self.service_decorator()
10191019
if request.headers.get("Accept") == "application/json":
10201020
return web.json_response(proof_reg_txn)

docs/demo/AliceGetsAPhone.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,9 @@ If you are running in a _local bash shell_, navigate to the `demo` directory in
142142
your fork/clone of the ACA-Py repository and run:
143143

144144
```bash
145-
TAILS_NETWORK=docker_tails-server LEDGER_URL=http://test.bcovrin.vonx.io ./run_demo faber --aip 10 --revocation --events
145+
TAILS_NETWORK=docker_tails-server LEDGER_URL=http://test.bcovrin.vonx.io ./run_demo faber --revocation --events
146146
```
147147

148-
(Note that we have to start faber with `--aip 10` for compatibility with mobile clients.)
149-
150148
The `TAILS_NETWORK` parameter lets the demo script know how to connect to the tails server (which should be running in a separate shell on the same machine).
151149

152150
#### Running in Play with Docker?
@@ -155,7 +153,7 @@ If you are running in _Play with Docker_, navigate to the `demo` folder in the
155153
clone of ACA-Py and run the following:
156154

157155
```bash
158-
PUBLIC_TAILS_URL=https://c4f7fbb85911.ngrok.io LEDGER_URL=http://test.bcovrin.vonx.io ./run_demo faber --aip 10 --revocation --events
156+
PUBLIC_TAILS_URL=https://c4f7fbb85911.ngrok.io LEDGER_URL=http://test.bcovrin.vonx.io ./run_demo faber --revocation --events
159157
```
160158

161159
The `PUBLIC_TAILS_URL` parameter lets the demo script know how to connect to the tails server. This can be running in another PWD session, or even on your local machine - the ngrok endpoint is public and will map to the correct location.

0 commit comments

Comments
 (0)