Flashlight changes brightness in specific circumstance

[acdunn10]

Verification

• I searched for similar bug reports and found none was relevant.

What happened?

Flashlight app changes brightness to high after closing

What should happen instead?

Brightness should return to the brightness set by user instead of high

Reproduction steps

• Set brightness to low or medium
• Open flashlight app
• Return to watchface by holding down side button

Brightness will be changed from low or medium to high

More details?

Noticed and wanted to report it, as I can't fix it myself.

Version

1.10.0

Companion app

No response

[taukakao]

I didn't test the correct version, so the following information is not correct:

Interesting that this doesn't affect clicking the button. Any other event I tested produces this bug. (Long, very long and double press, then timer finish and also notifications)

This shouldn't be the case since every one of these events call LoadApp which itself should reset the brightness here:

InfiniTime/src/displayapp/DisplayApp.cpp

Line 306 in 964f065

ApplyBrightness();

Only difference I can see is that ButtonPushed calls LoadPreviousScreen instead of directly calling LoadApp. I can't see why this matters tho since LoadPreviousScreen only calls LoadApp itself. So maybe a timing issue?

Also, after the display brightness is in the wrong state it will only change back if LoadPreviousScreen is called, not if LoadApp itself is called.

More research is required.

[minacode]

Edit: I am running a test build based on develop and cannot reproduce your issue.

ApplyBrightness has this weird check for invalid data where it defaults to High. I don't think that this is the bug, but we should keep it in mind.
Also I think that this behavior should be done inside the settingsController if necessary.

[taukakao]

After actually testing the current development branch I noticed that this is already fixed.

This issue is a duplicate of #1201 and was fixed by #1213

So this issue will be fixed in the next release.