Week number on Casio watch face is off by one

[RubixDev]

Verification

• I searched for similar bug reports (including closed issues) and found none was relevant.

What happened?

The calendar week number on the Casio watch face is always one too low.

What should happen instead?

The week number should start at 1 at the beginning of the year, not 0.

Reproduction steps

1. Select Casio watch face
2. Observe incorrect week number in top left corner of the watch face

More details?

Also happened on v1.15, but so far I've just always added one in my mind to get the correct number.

Version

v1.16.0

Companion app

Gadgetbridge v0.86.1

[SteveAmor]

Not sure if this helps #1122 (comment) to explain why there is (sometimes) a week 0

[mark9064]

I'm not sure I can reproduce this. The G7710 watchface shows week 2 currently, and it showed week 1 from the 29th Dec. What behaviour would you expect?

[RubixDev]

The linked comment clarifies a bit of what's happening. I'm using the 12 hour clock format and apparently the week number calculation works differently with that than with the 24 hour format. When I switch to 24-hour, it also shows week 2 right now, which is what I'd expect, but with 12-hour format it shows week 1 instead.

[mark9064]

Oh, didn't realise this was affected by 12/24h clock choice. Sorry about that!

I can understand the different modes there, but I'm not quite sure why it's different for 12 and 24h...

PS: for some reason GitHub didn't show your reply steve even though I refreshed? Wasn't ignoring you on purpose there!

[mark9064]

Right, it's as the watchface assumes 12h time = sunday start of week and that requires one of the datetime format modes that does that, and the only one that does starts on week 0