Skip to content

Commit a08fa5a

Browse files
feat: show caption languages in i18n strings
1 parent ab19a46 commit a08fa5a

File tree

12 files changed

+35
-3
lines changed

12 files changed

+35
-3
lines changed

android/src/main/kotlin/project/pipepipe/app/ui/component/player/PlayerControl.kt

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -771,11 +771,29 @@ private fun MoreMenu(
771771
)
772772

773773
// Available subtitles
774+
val autoGeneratedText = stringResource(MR.strings.player_subtitle_auto_generated)
774775
availableSubtitles.forEach { subtitle ->
776+
// Get localized language name using Locale
777+
val locale = java.util.Locale.forLanguageTag(subtitle.language)
778+
val localizedName = locale.getDisplayLanguage(java.util.Locale.getDefault())
779+
val displayText = if (localizedName.isNotBlank()) {
780+
if (subtitle.isAutoGenerated) {
781+
"$localizedName ($autoGeneratedText)"
782+
} else {
783+
localizedName
784+
}
785+
} else {
786+
if (subtitle.isAutoGenerated) {
787+
"${subtitle.language} ($autoGeneratedText)"
788+
} else {
789+
subtitle.language
790+
}
791+
}
792+
775793
DropdownMenuItem(
776794
text = {
777795
Text(
778-
text = subtitle.language,
796+
text = displayText,
779797
color = if (subtitle.isSelected)
780798
MaterialTheme.colorScheme.primary
781799
else

android/src/main/kotlin/project/pipepipe/app/ui/component/player/PlayerHelper.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ object PlayerHelper {
5555
val language: String,
5656
val trackGroup: TrackGroup,
5757
val trackIndex: Int,
58-
val isSelected: Boolean
58+
val isSelected: Boolean,
59+
val isAutoGenerated: Boolean = false
5960
)
6061

6162
inline fun Tracks.Group.forEachIndexed(action: (index: Int, item: Format) -> Unit) {

android/src/main/kotlin/project/pipepipe/app/ui/component/player/VideoPlayer.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,12 +474,16 @@ fun VideoPlayer(
474474
currentTracks.groups.filter { it.type == C.TRACK_TYPE_TEXT }.forEach { textGroup ->
475475
textGroup?.forEachIndexed { index, format ->
476476
val language = format.language ?: subtitleLanguageUnknown
477+
// Check if this is an auto-generated subtitle by checking the vssId format
478+
// Auto-generated subtitles have vssId starting with "a." (e.g., "a.en")
479+
val isAutoGenerated = format.id?.startsWith("a.") == true
477480
subtitles.add(
478481
SubtitleInfo(
479482
language = language,
480483
trackGroup = textGroup.mediaTrackGroup,
481484
trackIndex = index,
482-
isSelected = textGroup.isTrackSelected(index)
485+
isSelected = textGroup.isTrackSelected(index),
486+
isAutoGenerated = isAutoGenerated
483487
)
484488
)
485489
}

library/src/commonMain/moko-resources/base/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@
103103
<string name="player_skipped_category">Skipped %s</string>
104104
<string name="player_audio_language_default">Default</string>
105105
<string name="player_subtitle_language_unknown">Unknown</string>
106+
<string name="player_subtitle_auto_generated">auto-generated</string>
106107
<string name="player_play_video">Play video</string>
107108
<string name="sponsor_block_manual_skip_button">Skip</string>
108109
<string name="player_skip_segment">Skip segment</string>

library/src/commonMain/moko-resources/de/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,4 +436,5 @@
436436
<string name="about_become_supporter">Unterstützer werden</string>
437437
<string name="about_donate_description">Vielen Dank, dass du PipePipe nutzt! Wenn du es nützlich findest, erwäge bitte, ein Unterstützer auf Ko-Fi zu werden. Deine Unterstützung ist mir wichtig und hilft mir, weitere spannende neue Funktionen hinzuzufügen. Jeder Beitrag zählt! 😇</string>
438438
<string name="saved">Gespeichert</string>
439+
<string name="player_subtitle_auto_generated">automatisch generiert</string>
439440
</resources>

library/src/commonMain/moko-resources/es/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,4 +436,5 @@
436436
<string name="about_become_supporter">Conviértete en un patrocinador</string>
437437
<string name="about_donate_description">¡Gracias por usar PipePipe! Si lo encuentras útil, considera convertirte en un patrocinador en Ko-Fi. Tu apoyo es importante para mí y me ayuda a añadir más funciones nuevas y emocionantes. ¡Cada pequeña contribución cuenta! 😇</string>
438438
<string name="saved">Guardado</string>
439+
<string name="player_subtitle_auto_generated">generado automáticamente</string>
439440
</resources>

library/src/commonMain/moko-resources/fr/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,4 +436,5 @@
436436
<string name="about_become_supporter">Devenir un soutien</string>
437437
<string name="about_donate_description">Merci d\'utiliser PipePipe ! Si vous le trouvez utile, veuillez envisager de devenir un soutien sur Ko-Fi. Votre soutien est important pour moi et m\'aide à ajouter de nouvelles fonctionnalités passionnantes. Chaque contribution compte ! 😇</string>
438438
<string name="saved">Enregistré</string>
439+
<string name="player_subtitle_auto_generated">généré automatiquement</string>
439440
</resources>

library/src/commonMain/moko-resources/it/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,4 +436,5 @@
436436
<string name="about_become_supporter">Diventa un Sostenitore</string>
437437
<string name="about_donate_description">Grazie per aver usato PipePipe! Se lo trovi utile, considera di diventare un sostenitore su Ko-Fi. Il tuo supporto è importante per me e mi aiuta ad aggiungere nuove entusiasmanti funzionalità. Ogni contributo conta! 😇</string>
438438
<string name="saved">Salvato</string>
439+
<string name="player_subtitle_auto_generated">generato automaticamente</string>
439440
</resources>

library/src/commonMain/moko-resources/ja/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,4 +436,5 @@
436436
<string name="about_become_supporter">サポーターになる</string>
437437
<string name="about_donate_description">PipePipeをご利用いただきありがとうございます!もしお役に立てたなら、Ko-Fiでサポーターになることをご検討ください。皆様のサポートは私にとって重要であり、よりエキサイティングな新機能を追加するのに役立ちます。どんな小さな貢献でも大歓迎です!😇</string>
438438
<string name="saved">保存済み</string>
439+
<string name="player_subtitle_auto_generated">自動生成</string>
439440
</resources>

library/src/commonMain/moko-resources/vi/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,4 +436,5 @@
436436
<string name="about_become_supporter">Trở thành Người ủng hộ</string>
437437
<string name="about_donate_description">Cảm ơn bạn đã sử dụng PipePipe! Nếu bạn thấy ứng dụng hữu ích, vui lòng cân nhắc trở thành người ủng hộ trên Ko-Fi. Sự ủng hộ của bạn rất quan trọng đối với tôi và giúp tôi bổ sung thêm nhiều tính năng mới thú vị. Mọi đóng góp đều có giá trị! 😇</string>
438438
<string name="saved">Đã lưu</string>
439+
<string name="player_subtitle_auto_generated">tự động tạo</string>
439440
</resources>

0 commit comments

Comments
 (0)