[algorithm] More compact syntax for shaftProx check in loop

th-skam · web-flow · commit 68e2a6c29565 · 2025-08-14T09:17:00.000+02:00
diff --git a/src/sofa/collisionAlgorithm/algorithm/InsertionAlgorithm.h b/src/sofa/collisionAlgorithm/algorithm/InsertionAlgorithm.h
@@ -292,11 +292,9 @@ class InsertionAlgorithm : public BaseAlgorithm
             {
                 const BaseProximity::SPtr shaftProx = findClosestProxOnShaft(
                     m_couplingPts[i], l_shaftGeom.get(), projectOnShaft, getFilterFunc());
-                if (shaftProx)
-                {
-                    shaftProx->normalize();
-                    insertionOutput.add(shaftProx, m_couplingPts[i]);
-                }
+                if (!shaftProx) continue;
+                shaftProx->normalize();
+                insertionOutput.add(shaftProx, m_couplingPts[i]);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -292,11 +292,9 @@ class InsertionAlgorithm : public BaseAlgorithm`
`292`	`292`	`{`
`293`	`293`	`const BaseProximity::SPtr shaftProx = findClosestProxOnShaft(`
`294`	`294`	`m_couplingPts[i], l_shaftGeom.get(), projectOnShaft, getFilterFunc());`
`295`		`- if (shaftProx)`
`296`		`- {`
`297`		`- shaftProx->normalize();`
`298`		`- insertionOutput.add(shaftProx, m_couplingPts[i]);`
`299`		`- }`
	`295`	`+ if (!shaftProx) continue;`
	`296`	`+ shaftProx->normalize();`
	`297`	`+ insertionOutput.add(shaftProx, m_couplingPts[i]);`
`300`	`298`	`}`
`301`	`299`	`}`
`302`	`300`