[src] Overload add function with DetectionOutput signature to shorten code

Author: th-skam

src/CollisionAlgorithm/DataDetectionOutput.h

@@ -58,6 +58,11 @@ class DetectionOutput {
         m_output.push_back(PairDetection(p1,p2));
     }
 
+    inline void add(const DetectionOutput& addition) {
+        for (auto& it : addition)
+            this->add(it.first, it.second);
+    }
+
     inline const PairDetection & operator[](int i) const {
         return m_output[i];
     }

src/CollisionAlgorithm/algorithm/InsertionAlgorithm.cpp

@@ -119,10 +119,7 @@ void InsertionAlgorithm::doDetection()
         // Shaft collision sequence - Disable if coupling points have been added
         sofa::helper::AdvancedTimer::stepBegin("Shaft collision - " + this->getName());
         if (d_enableShaftCollision.getValue() && m_couplingPts.empty())
-        {
-            AlgorithmOutput shaftCollisions = shaftCollisionPhase();
-            for (auto& it : shaftCollisions) collisionOutput.add(it.first, it.second);
-        }
+            collisionOutput.add(shaftCollisionPhase());
         sofa::helper::AdvancedTimer::stepEnd("Shaft collision - " + this->getName());
     }
     else