Fix review comment for env make allocation

fangpenlin · fangpenlin · commit 44280aec2c6e · 2026-01-05T18:48:03.000-08:00
diff --git a/e2e/relay/helper_test.go b/e2e/relay/helper_test.go
@@ -209,7 +209,7 @@ func (c *Command) Start(ctx context.Context) {
 
 		slog.Info("Running command as a sub-process", "executable", exeFile, "args", c.Args)
 		c.cmd = exec.Command(exeFile, c.Args...)
-		c.cmd.Env = make([]string, len(env))
+		c.cmd.Env = make([]string, 0, len(env))
 		for k, v := range env {
 			c.cmd.Env = append(c.cmd.Env, fmt.Sprintf("%s=%s", k, v))
 		}

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,7 @@ func (c *Command) Start(ctx context.Context) {`
`209`	`209`
`210`	`210`	`slog.Info("Running command as a sub-process", "executable", exeFile, "args", c.Args)`
`211`	`211`	`c.cmd = exec.Command(exeFile, c.Args...)`
`212`		`- c.cmd.Env = make([]string, len(env))`
	`212`	`+ c.cmd.Env = make([]string, 0, len(env))`
`213`	`213`	`for k, v := range env {`
`214`	`214`	`c.cmd.Env = append(c.cmd.Env, fmt.Sprintf("%s=%s", k, v))`
`215`	`215`	`}`