Conversation
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
This PR adds Windows Docker image build support by creating a new goreleaser-windows job and corresponding goreleaser configuration for Windows binaries.
Key changes:
- New
goreleaser-windowsjob runs onwindows-2022runner and builds Windows Docker images for amd64 and arm64 - Created
.goreleaser-windows.yamlconfig with Windows-specific build settings (CGO disabled, windows GOOS, amd64/arm64 architectures) - Added minimal Windows Dockerfile using
nanoserver:ltsc2022base image - Modified job dependencies so main goreleaser job now depends on Windows job completion
Critical issue found:
- The
goreleaser-windowsjob is missing theactions/checkout@v3step before running git commands, which will cause the workflow to fail
Confidence Score: 2/5
- This PR cannot be merged as-is due to a critical syntax error that will cause the workflow to fail
- Score of 2 reflects a blocking issue: the goreleaser-windows job is missing the required checkout step, causing all git commands to fail. The Windows build configuration itself is sound, but the workflow will not execute successfully without this fix.
.github/workflows/release_build_infisical_cli.ymlrequires immediate attention - the checkout step must be added before the workflow can run
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/release_build_infisical_cli.yml | 2/5 | Added Windows build job but missing critical checkout step that will cause git commands to fail. Job dependency order may block releases if Windows builds fail. |
| .goreleaser-windows.yaml | 4/5 | New goreleaser config for Windows builds with proper CGO, ldflags, and multi-arch support. Missing docker manifests for unified tagging. |
| docker/windows | 5/5 | Simple Windows Dockerfile using nanoserver base image. Missing newline at EOF but otherwise functional. |
Sequence Diagram
sequenceDiagram
participant GH as GitHub Actions
participant WR as Windows Runner
participant UR as Ubuntu Runner
participant DH as Docker Hub
participant GR as GoReleaser
Note over GH: Tag Push (v*.*.*)
GH->>WR: Start goreleaser-windows job
WR->>WR: Fetch tags (FAILS - no checkout)
WR->>WR: Setup Go 1.19.3+
WR->>DH: Login to Docker Hub
WR->>WR: Setup Docker Buildx
WR->>GR: Run goreleaser-pro with windows config
GR->>GR: Build Windows binaries (amd64, arm64)
GR->>GR: Create Docker images (nanoserver:ltsc2022)
GR->>DH: Push windows-amd64 and windows-arm64 images
WR-->>GH: Windows job complete
GH->>UR: Start goreleaser job (needs windows)
UR->>UR: Checkout code
UR->>UR: Setup Go, Docker, OSXCross
UR->>GR: Run goreleaser-pro
GR->>GR: Build Linux/Darwin binaries
GR->>GR: Create Linux Docker images (Alpine)
GR->>DH: Push linux-amd64 and linux-arm64 images
GR->>DH: Create manifest tags (latest, version)
UR->>UR: Publish to CloudSmith, S3, etc.
UR-->>GH: Goreleaser job complete
GH->>UR: Start npm-release job
UR->>UR: Publish to NPM registry
3 files reviewed, 4 comments
| goreleaser: | ||
| runs-on: ubuntu-latest-8-cores | ||
| # needs: [cli-integration-tests] | ||
| needs: [goreleaser-windows] # For quick iteration, we're releasing Windows images first |
Contributor
There was a problem hiding this comment.
style: The comment says "For quick iteration, we're releasing Windows images first", but this creates a hard dependency where the main Linux build cannot complete without Windows builds succeeding first. If Windows builds fail, the entire release pipeline (including npm release) will be blocked.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release_build_infisical_cli.yml
Line: 87:87
Comment:
**style:** The comment says "For quick iteration, we're releasing Windows images first", but this creates a hard dependency where the main Linux build cannot complete without Windows builds succeeding first. If Windows builds fail, the entire release pipeline (including npm release) will be blocked.
How can I resolve this? If you propose a fix, please make it concise.
carlosmonastyrski
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Added build for Windows-based CLI docker images.
Type ✨