fix: update windows release to docker buildx v4#32
Merged
Conversation
carlosmonastyrski
approved these changes
Oct 10, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
Updated the Windows release job to use docker/setup-buildx-action@v3 instead of v2 for building Windows Docker images.
- Upgraded buildx version in
goreleaser-windowsjob from v2 to v3 - Note: PR title says "v4" but actual change is to v3
- Main
goreleaserjob still uses buildx v2 at line 98, creating version inconsistency across the workflow
Confidence Score: 3/5
- This PR is moderately safe to merge but has an inconsistency that should be addressed
- The buildx upgrade to v3 for Windows is a valid improvement for compatibility, but the workflow now has mixed versions (v2 in goreleaser job, v3 in goreleaser-windows job). This inconsistency should be resolved by updating both jobs to v3 for uniformity.
.github/workflows/release_build_infisical_cli.yml- line 98 should be updated to match the Windows job's buildx version
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/release_build_infisical_cli.yml | 3/5 | Updated Windows job to use buildx v3, but inconsistency remains with main goreleaser job still on v2 |
Sequence Diagram
sequenceDiagram
participant Tag as Git Tag Push
participant WinJob as goreleaser-windows Job
participant MainJob as goreleaser Job
participant NPMJob as npm-release Job
participant DockerHub as Docker Hub
participant GitHub as GitHub Releases
participant NPM as NPM Registry
Tag->>WinJob: Trigger workflow
WinJob->>DockerHub: Login
WinJob->>WinJob: Setup Docker Buildx v3
WinJob->>WinJob: Setup Go & fetch tags
WinJob->>DockerHub: Build & push Windows images
WinJob->>GitHub: Create Windows release artifacts
WinJob->>MainJob: Dependency satisfied
MainJob->>DockerHub: Login
MainJob->>MainJob: Setup Docker Buildx v2
MainJob->>MainJob: Setup Go & OSXCross
MainJob->>DockerHub: Build & push Linux/Mac images
MainJob->>GitHub: Create main release artifacts
MainJob->>MainJob: Upload to CloudSmith & S3
MainJob->>NPMJob: Dependency satisfied
NPMJob->>NPMJob: Extract version & setup Node
NPMJob->>NPM: Publish package
Additional Comments (1)
-
.github/workflows/release_build_infisical_cli.yml, line 98 (link)logic: Inconsistent buildx versions - this job uses
v2while the Windows job usesv3. Should both be updated tov3for consistency?
1 file reviewed, 1 comment
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated buildx to v3