Skip to content

Commit 2a358ce

Browse files
author
Victor Santos
committed
refactor(api): streamline DynamicSecret and DynamicSecretLease by removing unused fields and updating method signatures for clarity
1 parent 867820f commit 2a358ce

File tree

2 files changed

+23
-18
lines changed

2 files changed

+23
-18
lines changed

infisical_sdk/api_types.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -332,10 +332,7 @@ class DynamicSecret(BaseModel):
332332
maxTTL: Optional[str] = None
333333
status: Optional[str] = None
334334
statusDetails: Optional[str] = None
335-
projectGatewayId: Optional[str] = None
336-
gatewayId: Optional[str] = None
337335
usernameTemplate: Optional[str] = None
338-
gatewayV2Id: Optional[str] = None
339336
metadata: Optional[List[Dict[str, str]]] = field(default_factory=list)
340337
inputs: Optional[Any] = None
341338

@@ -362,7 +359,6 @@ class DynamicSecretLease(BaseModel):
362359
externalEntityId: str
363360
status: Optional[str] = None
364361
statusDetails: Optional[str] = None
365-
config: Optional[Any] = None
366362
dynamicSecret: Optional[DynamicSecret] = None
367363

368364
@classmethod

infisical_sdk/resources/dynamic_secrets.py

Lines changed: 23 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -281,40 +281,49 @@ def update(
281281
name: str,
282282
project_slug: str,
283283
environment_slug: str,
284-
data: Dict[str, Any],
285284
path: str = "/",
286-
default_ttl: str = None,
287-
max_ttl: str = None,
288-
new_name: str = None,
289-
inputs: Dict[str, Any] = None,
290-
metadata: Optional[List[Dict[str, str]]] = None) -> DynamicSecret:
285+
default_ttl: Optional[str] = None,
286+
max_ttl: Optional[str] = None,
287+
new_name: Optional[str] = None,
288+
inputs: Optional[Dict[str, Any]] = None,
289+
metadata: Optional[List[Dict[str, str]]] = None,
290+
username_template: Optional[str] = None) -> DynamicSecret:
291291
"""Update an existing dynamic secret.
292292
293293
Args:
294294
name: The current name of the dynamic secret.
295295
project_slug: The slug of the project.
296296
environment_slug: The slug of the environment.
297-
data: The provider-specific configuration to update.
298297
path: The path to the dynamic secret. Defaults to "/".
299298
default_ttl: The new default time to live for leases (e.g., "1h").
300299
max_ttl: The new maximum time to live for leases (e.g., "24h").
301300
new_name: The new name for the dynamic secret.
302-
inputs: Updated provider inputs.
301+
inputs: Updated provider-specific configuration inputs.
303302
metadata: Updated metadata list with 'key' and 'value' items.
303+
username_template: The new username template for the dynamic secret.
304304
305305
Returns:
306306
The updated dynamic secret.
307307
"""
308+
data: Dict[str, Any] = {}
309+
if inputs is not None:
310+
data["inputs"] = inputs
311+
if default_ttl is not None:
312+
data["defaultTTL"] = default_ttl
313+
if max_ttl is not None:
314+
data["maxTTL"] = max_ttl
315+
if new_name is not None:
316+
data["newName"] = new_name
317+
if metadata is not None:
318+
data["metadata"] = metadata
319+
if username_template is not None:
320+
data["usernameTemplate"] = username_template
321+
308322
request_body = {
309323
"projectSlug": project_slug,
310324
"environmentSlug": environment_slug,
311-
"data": data,
312325
"path": path,
313-
"defaultTTL": default_ttl,
314-
"maxTTL": max_ttl,
315-
"newName": new_name,
316-
"inputs": inputs,
317-
"metadata": metadata,
326+
"data": data,
318327
}
319328

320329
result = self.requests.patch(

0 commit comments

Comments
 (0)