fix: requested changes

Author: varonix0

README.md

@@ -47,11 +47,11 @@ secrets = client.secrets.list_secrets(project_id="<project-id>", environment_slu
 
 ## InfisicalSDKClient Parameters
 
-The `InfisicalSDKClient` takes the following parameters, which are used a global configuration.
+The `InfisicalSDKClient` takes the following parameters, which are used as a global configuration for the lifetime of the SDK instance.
 
 - **host** (`str`, _Optional_): The host URL for your Infisical instance. Defaults to `https://app.infisical.com`.
-- **token** (`str`, _Optional_): Specify a authentication token to use for all requests. If provided, you will not need to call any of the `auth` methods. Defaults to `None`
-- **cache_ttl** (`int`, _Optional_): The SDK has an inbuilt client-side cache mechanism for secrets, which greatly improves speed for the secret methods. By default secrets are cached for 5 minutes. You can disable caching by setting `cache_ttl` to `None`. The value is in seconds, so `300` equates to 5 minutes caching TTL. Default is `300` seconds.
+- **token** (`str`, _Optional_): Specify an authentication token to use for all requests. If provided, you will not need to call any of the `auth` methods. Defaults to `None`
+- **cache_ttl** (`int`, _Optional_): The SDK has built-in client-side caching for secrets, greatly improving response times. By default, secrets are cached for 1 minute (60 seconds). You can disable caching by setting `cache_ttl` to `None`, or adjust the duration in seconds as needed.
 
 ```python
 client = InfisicalSDKClient(

infisical_sdk/client.py

@@ -7,13 +7,13 @@
 from infisical_sdk.util import SecretsCache
 
 class InfisicalSDKClient:
-    def __init__(self, host: str, token: str = None, cache_ttl: int = 300):
+    def __init__(self, host: str, token: str = None, cache_ttl: int = 60):
         """
         Initialize the Infisical SDK client.
 
         :param str host: The host URL for your Infisical instance. Will default to `https://app.infisical.com` if not specified.
         :param str token: The authentication token for the client. If not specified, you can use the `auth` methods to authenticate.
-        :param int cache_ttl: The time to live for the secrets cache. This is the number of seconds that secrets fetched from the API will be cached for. Set to `None` to disable caching.
+        :param int cache_ttl: The time to live for the secrets cache. This is the number of seconds that secrets fetched from the API will be cached for. Set to `None` to disable caching. Defaults to `60` seconds.
         """
 
         self.host = host

infisical_sdk/resources/secrets.py

@@ -37,7 +37,7 @@ def list_secrets(
             params["tagSlugs"] = ",".join(tag_filters)
 
 
-        cache_key = self.cache.compute_cache_key("list_secrets", **params)
+        cache_key = self.cache.compute_cache_key(CACHE_KEY_LIST_SECRETS, **params)
         if self.cache.enabled:
           cached_response = self.cache.get(cache_key)
 
@@ -76,7 +76,14 @@ def get_secret_by_name(
           "version": version
         }
 
-        cache_key = self.cache.compute_cache_key(CACHE_KEY_SINGLE_SECRET, **params)
+        cache_params = {
+           "project_id": project_id,
+           "environment_slug": environment_slug,
+           "secret_path": secret_path,
+           "secret_name": secret_name,
+        }
+
+        cache_key = self.cache.compute_cache_key(CACHE_KEY_SINGLE_SECRET, **cache_params)
 
         if self.cache.enabled:
           cached_response = self.cache.get(cache_key)
@@ -125,6 +132,18 @@ def create_secret_by_name(
             model=SingleSecretResponse
         )
 
+
+        if self.cache.enabled:
+          cache_params = {
+            "project_id": project_id,
+            "environment_slug": environment_slug,
+            "secret_path": secret_path,
+            "secret_name": secret_name,
+          }
+
+          cache_key = self.cache.compute_cache_key(CACHE_KEY_SINGLE_SECRET, **cache_params)
+          self.cache.set(cache_key, result.data.secret)
+
         return result.data.secret
 
     def update_secret_by_name(
@@ -160,6 +179,18 @@ def update_secret_by_name(
             model=SingleSecretResponse
         )
 
+        if self.cache.enabled:
+           cache_params = {
+            "project_id": project_id,
+            "environment_slug": environment_slug,
+            "secret_path": secret_path,
+            "secret_name": current_secret_name,
+           }
+
+           cache_key = self.cache.compute_cache_key(CACHE_KEY_SINGLE_SECRET, **cache_params)
+           self.cache.unset(cache_key)
+           
+
         return result.data.secret
 
     def delete_secret_by_name(
@@ -182,4 +213,15 @@ def delete_secret_by_name(
             model=SingleSecretResponse
         )
 
+        if self.cache.enabled:
+          cache_params = {
+            "project_id": project_id,
+            "environment_slug": environment_slug,
+            "secret_path": secret_path,
+            "secret_name": secret_name,
+          }
+
+          cache_key = self.cache.compute_cache_key(CACHE_KEY_SINGLE_SECRET, **cache_params)
+          self.cache.unset(cache_key)
+
         return result.data.secret

setup.cfg

@@ -1,3 +1,3 @@
 [flake8]
 max-line-length=99
-exclude = .venv,test.py
+exclude = .venv,test.py,sink