Skip to content

Commit 0adcd40

Browse files
feat: refactor to enum
1 parent cd0b40f commit 0adcd40

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

influxdb_client_3/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,8 @@ def __init__(
209209
self._database = database
210210
self._token = token
211211

212-
write_type = DefaultWriteOptions['write_type']
213-
write_precision = DefaultWriteOptions['write_precision']
212+
write_type = DefaultWriteOptions.write_type.value
213+
write_precision = DefaultWriteOptions.write_precision.value
214214
gzip_threshold = None
215215
if isinstance(write_client_options, dict) and write_client_options.get('write_options') is not None:
216216
write_opts = write_client_options['write_options']

influxdb_client_3/write_client/client/write_api.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,14 @@ class WriteType(Enum):
4141
DEFAULT_GZIP_THRESHOLD = 1000
4242

4343
#todo: convert to enum
44-
DefaultWriteOptions = {
45-
'write_type': WriteType.synchronous,
46-
'write_precision': WritePrecision.NS
47-
}
44+
# DefaultWriteOptions = {
45+
# 'write_type': WriteType.synchronous,
46+
# 'write_precision': WritePrecision.NS
47+
# }
48+
class DefaultWriteOptions(Enum):
49+
write_type = WriteType.synchronous
50+
write_precision = WritePrecision.NS
51+
4852

4953

5054
class WriteOptions(object):

tests/test_influxdb_client_3.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ async def test_query_async(self):
7575
assert {'data': 'query_type', 'reference': 'sql', 'value': -1.0} in result_list
7676

7777
def test_default_client(self):
78-
expected_precision = DefaultWriteOptions['write_precision']
79-
expected_write_type = DefaultWriteOptions['write_type']
78+
expected_precision = DefaultWriteOptions.write_precision.value
79+
expected_write_type = DefaultWriteOptions.write_type.value
8080
expected_gzip_threshold = None
8181
expected_gzip_enabled = False
8282

0 commit comments

Comments
 (0)