Skip to content

Commit f6d433a

Browse files
fix: replace direct instantiation with context manager in InfluxDBClient3 tests
1 parent 5941412 commit f6d433a

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

tests/test_influxdb_client_3.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -357,28 +357,27 @@ def test_url_with_path_prefix(self):
357357
server.expect_request('/prefix/prefix1/ping').respond_with_json(
358358
response_json={"version": "3.0"},
359359
)
360-
version = InfluxDBClient3(
360+
with InfluxDBClient3(
361361
host=f'http://{server.host}:{server.port}/prefix/prefix1',
362362
org="ORG",
363363
database="DB",
364364
token="TOKEN"
365-
).get_server_version()
366-
assert version == "3.0"
365+
) as client:
366+
assert client.get_server_version() == "3.0"
367367

368368
def test_url_error_without_path_prefix(self):
369369
server = self.http_server
370370
server.expect_request('/prefix/ping').respond_with_json(
371371
response_json={"version": "3.0"},
372372
)
373-
try:
374-
InfluxDBClient3(
373+
with InfluxDBClient3(
375374
host=f'http://{server.host}:{server.port}',
376375
org="ORG",
377376
database="DB",
378377
token="TOKEN"
379-
).get_server_version()
380-
except ApiException:
381-
self.assertRaises(ApiException)
378+
) as client:
379+
with self.assertRaises(ApiException):
380+
client.get_server_version()
382381

383382

384383
if __name__ == '__main__':

tests/test_write_local_server.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,13 @@ def test_write_with_path_prefix(self):
4545
httpserver.start()
4646
httpserver.expect_request("/prefix/prefix1/api/v2/write").respond_with_data(status=200)
4747

48-
InfluxDBClient3(
49-
host=(httpserver.url_for("/prefix/prefix1")), org="ORG", database="DB", token="TOKEN",
50-
write_client_options=write_client_options(
51-
write_options=WriteOptions(write_type=WriteType.synchronous)
52-
)
53-
).write(self.SAMPLE_RECORD)
48+
with InfluxDBClient3(
49+
host=(httpserver.url_for("/prefix/prefix1")), org="ORG", database="DB", token="TOKEN",
50+
write_client_options=write_client_options(
51+
write_options=WriteOptions(write_type=WriteType.synchronous)
52+
)
53+
) as client:
54+
client.write(self.SAMPLE_RECORD)
5455

5556
self.assert_request_made(httpserver, RequestMatcher(
5657
method="POST", uri="/prefix/prefix1/api/v2/write",

0 commit comments

Comments
 (0)