Skip to content

Commit c6ec445

Browse files
committed
cleanup of centos and buildah images
1 parent 0aab6b5 commit c6ec445

13 files changed

+206
-262
lines changed

Dockerfile-java-centos

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,16 @@ RUN yum update -y &&\
88
sed -i 's/enabled=0/enabled=1/' /etc/yum.repos.d/CentOS-Linux-PowerTools.repo &&\
99
yum install -y --setopt=tsflags=nodocs --setopt=override_install_langs=en_US.utf8\
1010
java-11-openjdk-headless\
11-
boost\
1211
boost-system\
1312
boost-thread\
1413
boost-serialization\
1514
boost-regex\
1615
boost-chrono\
1716
boost-date-time\
1817
boost-atomic\
19-
boost-iostreams &&\
18+
boost-iostreams\
19+
procps-ng\
20+
freetype &&\
2021
yum clean all &&\
2122
rm -rf /var/cache/yum
2223

@@ -28,7 +29,7 @@ RUN rpm --nodeps -iv /tmp/*.rpm && rm -f /tmp/*.rpm
2829

2930
WORKDIR /
3031

31-
ENV JAVA_HOME /usr/lib/jvm/java-11-openjdk-amd64
32+
ENV JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64
3233
ENV LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/rdkit/gmwrapper
3334
ENV CLASSPATH=/rdkit/gmwrapper/org.RDKit.jar
3435
ENV RDBASE=/usr/share/RDKit

Dockerfile-python3-centos

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,17 @@ RUN yum update -y &&\
1414
python3-pip\
1515
python3-setuptools\
1616
python3-six\
17-
boost\
17+
boost-system\
18+
boost-thread\
19+
boost-serialization\
20+
boost-regex\
21+
boost-chrono\
22+
boost-date-time\
23+
boost-atomic\
24+
boost-iostreams\
1825
boost-python3\
19-
freetype &&\
26+
freetype\
27+
procps-ng &&\
2028
yum clean -y all &&\
2129
rm -rf /var/cache/yum
2230

buildah/Dockerfile-buildah

Lines changed: 28 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -7,32 +7,36 @@ FROM centos:8
77
LABEL maintainer="Tim Dudgeon<[email protected]>"
88

99

10-
RUN yum -y update &&\
10+
RUN yum install -y\
11+
--setopt=tsflags=nodocs\
12+
--setopt=override_install_langs=en_US.utf8\
13+
epel-release &&\
14+
yum -y update &&\
1115
sed -i 's/enabled=0/enabled=1/' /etc/yum.repos.d/CentOS-Linux-PowerTools.repo &&\
1216
yum install -y\
13-
--setopt=tsflags=nodocs\
14-
--setopt=override_install_langs=en_US.utf8\
15-
tk-devel\
16-
readline-devel\
17-
zlib-devel\
18-
bzip2-devel\
19-
sqlite-devel\
20-
@development\
21-
cmake3\
22-
python3-devel\
23-
python3-numpy\
24-
boost-devel\
25-
boost-python3-devel\
26-
eigen3-devel\
27-
java-11-openjdk-devel\
28-
swig\
29-
git\
30-
wget\
31-
zip\
32-
unzip\
33-
freetype-devel\
34-
cairo-devel\
35-
buildah &&\
17+
--setopt=tsflags=nodocs\
18+
--setopt=override_install_langs=en_US.utf8\
19+
tk-devel\
20+
readline-devel\
21+
zlib-devel\
22+
bzip2-devel\
23+
sqlite-devel\
24+
@development\
25+
cmake3\
26+
python3-devel\
27+
python3-numpy\
28+
boost-devel\
29+
boost-python3-devel\
30+
eigen3-devel\
31+
java-11-openjdk-devel\
32+
swig\
33+
git\
34+
wget\
35+
zip\
36+
unzip\
37+
freetype-devel\
38+
cairo-devel\
39+
buildah &&\
3640
yum clean all &&\
3741
rm -rf /var/cache/yum
3842

buildah/Dockerfile-cartridge

Lines changed: 0 additions & 13 deletions
This file was deleted.

buildah/README.md

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# Buildah builds for RDkit
22

3-
This directory contains scripts for using [buildah](https://buildah.io/) to build minimal RDKit Python3 images.
4-
These are based on Fedora as a base OS (because of RDKit's requirement for a modern version of boost that
5-
is not present in the current Centos7 OS - we may switch back to using Centos once this is resolved and Centos
6-
support for Python3 is improved).
3+
This directory contains scripts for using [buildah](https://buildah.io/) to build minimal RDKit Python3 and Java images.
4+
These are based on Centos8. The images should be functionally equivalent to the ones built with "classic" approach in
5+
top level directory, but are significantly smaller. We expect that these images will replace the "classic" ones at some
6+
stage and we may do the same for the Debian based images as well.
77

88
The build is done in a Docker container to provide a consistent build environment.
99

10-
The resulting `buildah` image can be pushed to Docker and then run as a standard container image for Docker and other
10+
The resulting `buildah` images can be pushed to Docker and then run as a standard container image for Docker and other
1111
container runtimes.
1212

1313
## To build
@@ -27,11 +27,7 @@ looks for images and containers. Also note that this runs as a privleged contain
2727

2828
You should see a bash prompt from inside the container.
2929

30-
### Run the build
31-
Define the `RDKIT_BRANCH` environment variable that specifies the RDKit branch to use:
32-
```
33-
export RDKIT_BRANCH=Release_2018_09_3
34-
```
30+
### Run the Python build
3531

3632
Build RDKit from the source code on that branch:
3733

@@ -45,17 +41,23 @@ Build the container image:
4541
./buildah-python3-image.sh
4642
```
4743

48-
Note: the two previous steps can be run using this one command: `buildah-python3.sh`
49-
5044
Check the output of the last step for the precise details of what to push.
5145
The command listed below is just an example.
5246
You need to do this from the host machine (not inside the container):
5347
```
54-
sudo buildah push informaticsmatters/rdkit-python3-mini:Release_2018_03_2 docker-daemon:informaticsmatters/rdkit-python3-mini:Release_2018_03_2
48+
sudo buildah push informaticsmatters/rdkit-python3-mini:latest docker-daemon:informaticsmatters/rdkit-python3-mini:latest
5549
```
5650

57-
## RDKit cartridge build
51+
### Run the Java build
52+
53+
The process is the same as for the Python image, just use the files with -java- rather than -python3-
54+
55+
56+
## Image sizes
57+
58+
These images are significantly smaller than the "classic" onces for Centos.
59+
60+
The Python image is 657MB compared with 741MB.
61+
The Java image is 519MB compared with 848MB.
5862

59-
This directory also contains files related to building the RDKit cartridge in a similar manner.
60-
These files are not yet operational and should be ignored.
6163

buildah/buildah-build-cartridge.sh

Lines changed: 0 additions & 68 deletions
This file was deleted.

buildah/buildah-build-cartridge2.sh

Lines changed: 0 additions & 64 deletions
This file was deleted.

buildah/buildah-build-cartridge3.sh

Lines changed: 0 additions & 52 deletions
This file was deleted.

0 commit comments

Comments
 (0)