feat: Simpler dev-container (no docker-in-docker)

Author: Alan Christie

.devcontainer/Dockerfile

@@ -14,6 +14,6 @@ RUN pip install -r /tmp/requirements.txt \
     && curl -LO "https://dl.k8s.io/release/v${KUBECTL_VERSION}/bin/linux/${PLATFORM}/kubectl" \
     && install -o root -g root -m 0755 kubectl /usr/local/bin/kubectl
 
-# Set KUBECONFIG (to dev container default config)
-# The user can (and is encouraged to) change this
+# Set KUBECONFIG (to the dev container's default config).
+# The user can (and is encouraged to) change this from the terminal.
 ENV KUBECONFIG=/home/vscode/.kube/config

.devcontainer/devcontainer.json

@@ -1,7 +1,7 @@
 // For format details, see https://aka.ms/devcontainer.json. For config options, see the
 // README at: https://github.com/devcontainers/templates/tree/main/src/python
 {
-	"name": "Kubernetes Ansible Python",
+	"name": "Kubernetes Ansible Projects",
 	"build": {
     "dockerfile": "Dockerfile",
     // Args is one of arm64 or amd64
@@ -10,31 +10,25 @@
     }
   },
 	"features": {
-		"ghcr.io/devcontainers/features/docker-in-docker:2": {
-			"moby": true,
-			"azureDnsAutoDetection": true,
-			"installDockerBuildx": true,
-			"installDockerComposeSwitch": true,
-			"version": "latest",
-			"dockerDashComposeVersion": "v2"
-		},
 		"ghcr.io/devcontainers/features/git:1": {
 			"ppa": true,
 			"version": "os-provided"
 		}
 	},
-  // We mount bash history in an attempt to preserver history
-  // between container restarts
+  // The user will need a ~/k8s-config directory where, as a matter of style
+  // we tend to keep our kubernetes configuration files. The user will also
+  // need a ~/.kube directory.
+  //
+  // We mount bash history in an attempt to preserver history between container restarts
   // (see https://code.visualstudio.com/remote/advancedcontainers/persist-bash-history)
   //
-  // The user will also need a ~/k8s-config directory (kubernetes config files)
-  // as well as a ~/.kube directory
   "mounts": [
       "source=${localEnv:HOME}/.gitconfig,target=/home/vscode/.gitconfig,type=bind,consistency=cached",
       "source=${localEnv:HOME}/k8s-config,target=/home/vscode/k8s-config,type=bind,consistency=cached",
       "source=${localEnv:HOME}/.kube,target=/home/vscode/.kube,type=bind,consistency=cached",
       "source=projectname-bashhistory,target=/commandhistory,type=volume"
   ],
+  // Studio Code custom module/plugins to load.
   "customizations": {
     "vscode": {
       "extensions": [
@@ -44,7 +38,6 @@
         "eamodio.gitlens",
         "github.vscode-github-actions",
         "ms-kubernetes-tools.vscode-kubernetes-tools",
-        "ms-python.vscode-pylance",
         "sourcery.sourcery",
         "streetsidesoftware.code-spell-checker",
         "trond-snekvik.simple-rst",
@@ -53,8 +46,11 @@
       ]
     }
   },
+  // Things to do once the container's available...
   "postCreateCommand": {
     "Fix Volume Permissions": "sudo chown -R $(whoami): /commandhistory"
 	},
+  // Do we expect to expose ports the user needs to connect to?
+  // If so list them (as integers) here.
   "forwardPorts": []
 }