Skip to content

Commit 645e90f

Browse files
author
Alan Christie
committed
- Unit tests for parameter_utils
1 parent 51d36d7 commit 645e90f

File tree

5 files changed

+48
-2
lines changed

5 files changed

+48
-2
lines changed

src/python/pipelines_utils/parameter_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def expandValues(inputs, count, name):
5757
if len(inputs) == count:
5858
expanded = inputs
5959
elif len(inputs) == 1:
60-
expanded = [inputs[0] for i in range(count)]
60+
expanded = inputs * count
6161
else:
62-
raise ValueError('Incompatible number of values for ' + name)
62+
raise ValueError('Incompatible number of values for ' + name)
6363
return expanded

src/python/setup.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@
4242
'Topic :: Software Development :: Build Tools',
4343
],
4444

45+
# Root of the test suite
46+
test_suite = 'test',
47+
4548
install_requires=[],
4649

4750
zip_safe=False,

src/python/test/__init__.py

Whitespace-only changes.

src/python/test/pipelines_utils/__init__.py

Whitespace-only changes.
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
import unittest
2+
3+
from pipelines_utils import parameter_utils
4+
5+
6+
class ParameterUtilsTestCase(unittest.TestCase):
7+
8+
def test_split_values(self):
9+
"""Verifies basic feature.
10+
"""
11+
result = parameter_utils.splitValues('1,2,3')
12+
self.assertEqual([1.0, 2.0, 3.0], result)
13+
14+
def test_expand_values_1_to_3(self):
15+
"""Verifies basic feature.
16+
"""
17+
result = parameter_utils.expandValues([1], 3, 'blob')
18+
self.assertEqual([1, 1, 1], result)
19+
20+
def test_expand_values_3(self):
21+
"""Verifies basic feature.
22+
"""
23+
result = parameter_utils.expandValues([1, 1, 1], 3, 'blob')
24+
self.assertEqual([1, 1, 1], result)
25+
26+
def test_expand_values_value_error(self):
27+
"""Verifies handling of odd inputs.
28+
"""
29+
got_excpetion = False
30+
try:
31+
parameter_utils.expandValues([1, 1], 3, 'blob')
32+
except ValueError as e:
33+
self.assertTrue('Inc ompatible number of values for blob', e)
34+
got_excpetion = True
35+
self.assertTrue(got_excpetion)
36+
37+
def test_expand_parameters(self):
38+
"""Verifies expansion of multiple parameters.
39+
"""
40+
params_a = ([1], 'a')
41+
params_b = ([2, 2, 2], 'b')
42+
result = parameter_utils.expandParameters(params_a, params_b)
43+
self.assertEquals(([1, 1, 1], [2, 2, 2]), result)

0 commit comments

Comments
 (0)