Skip to content

Commit 4f228b7

Browse files
Issue 26 - changes for remote execution (#28)
* - Pipeline adjustments for new (remote) cell executor (where params are placed in a config file) - Adds pull policy to sdposter (default is Always) - Adds 'retry' to gitignore * - Use of literal | in nextflow configs * - publishDir is now $baseDir/results (mode symlink) * - Ansible now display tag of poster image * - Experiment with 'copy' mode * - Now using move for results * - Removed docker config * - Removed content from nextflow config files
1 parent 29b0d5c commit 4f228b7

23 files changed

+44
-49
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ work
1212
.nextflow.log*
1313
/tmp
1414
**/*.egg-info
15-
**/.DS_Store
15+
**/.DS_Store
16+
*.retry

openshift/ansible/ansible.cfg

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
[defaults]
2+
callback_whitelist = profile_tasks
23
inventory = inventory
4+
nocows = 1

openshift/ansible/roles/pipelines/files/post-service-descriptors.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ parameters:
2121
value: latest
2222
- name: POSTER_SA
2323
value: squonk
24+
- name: PULL_POLICY
25+
value: Always
2426

2527
objects:
2628

@@ -42,5 +44,6 @@ objects:
4244
containers:
4345
- image: squonk/rdkit-pipelines-sdposter:${POSTER_IMAGE_TAG}
4446
name: pipelines-sd-poster
47+
imagePullPolicy: ${PULL_POLICY}
4548

4649
restartPolicy: Never

openshift/ansible/roles/pipelines/tasks/main.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
shell: oc delete jobs/{{ job_name }}
2222
when: jobs_result.stdout | regex_search('^%s' % job_name, multiline=True)
2323

24-
- name: Run SD poster job (always)
24+
- name: Run SD poster job (always) (tag={{ oc_pipelines_sd_poster_image_tag }})
2525
shell: >
2626
oc process
2727
-f {{ role_path }}/files/post-service-descriptors.yaml

src/nextflow/docking/plip.config

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1 @@
1-
docker.enabled = true
2-
docker.mountFlags = 'z'
3-
docker.runOptions = '-u $(id -u):$(id -g)'
4-
process.container = 'informaticsmatters/pli:latest'
1+
// Intentionally Empty
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
docker.enabled = true
2-
docker.mountFlags = 'z'
3-
process.container = 'informaticsmatters/pli:latest'
1+
// Intentionally Empty

src/nextflow/docking/plip.nsd.nf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ process joiner {
5151

5252
container 'informaticsmatters/pli:latest'
5353
beforeScript 'chmod g+w .'
54-
publishDir baseDir, mode: 'link'
54+
publishDir "$baseDir/results", mode: 'move'
5555

5656
input:
5757
file parts from scored_parts.collect()

src/nextflow/docking/plip.nsd.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,5 @@ inputRoutes:
4949
- route: "FILE"
5050
outputRoutes:
5151
- route: "FILE"
52-
nextflowParams: "${binding.variables.containsKey('score') ? ' --score ' + score: ''}"
52+
nextflowParams: |
53+
${binding.variables.containsKey('score') ? 'params.score = ' + score : ''}

src/nextflow/docking/rdock.config

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1 @@
1-
docker.enabled = true
2-
// allow to run with SELinux
3-
docker.mountFlags = 'z'
4-
// this runs the containers as the current user
5-
docker.runOptions = '-u $(id -u):$(id -g)'
6-
// See here for information on this image: https://github.com/InformaticsMatters/rdock_docker
7-
process.container = 'informaticsmatters/rdock-mini:latest'
1+
// Intentionally Empty
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
docker.enabled = true
2-
docker.mountFlags = 'z'
3-
process.container = 'informaticsmatters/rdkit_pipelines'
1+
// Intentionally Empty

0 commit comments

Comments
 (0)