Skip to content

Commit a2ce0ab

Browse files
author
Alan Christie
committed
fix: Ordinal is now a required property
1 parent a99d5e7 commit a2ce0ab

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

decoder/job-definition-schema.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -415,6 +415,7 @@ definitions:
415415
minimum: 1
416416
required:
417417
- name
418+
- ordinal
418419

419420
# A test input, a string or array of strings
420421
test-input:

tests/test_validate_job_schema.py

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,10 @@ def test_validate_test_run_groups():
257257
demo_job: Dict[str, Any] = text["jobs"]["demo"]
258258
demo_job["tests"] = {
259259
"basic-1": {
260-
"run-groups": [{"name": "demo-1"}, {"name": "demo-2", "ordinal": 1}],
260+
"run-groups": [
261+
{"name": "demo-1", "ordinal": 1},
262+
{"name": "demo-2", "ordinal": 1},
263+
],
261264
},
262265
}
263266

@@ -266,3 +269,20 @@ def test_validate_test_run_groups():
266269

267270
# Assert
268271
assert error is None
272+
273+
274+
def test_validate_test_run_groups_without_ordinal():
275+
# Arrange
276+
text: Dict[str, Any] = deepcopy(_MINIMAL)
277+
demo_job: Dict[str, Any] = text["jobs"]["demo"]
278+
demo_job["tests"] = {
279+
"basic-1": {
280+
"run-groups": [{"name": "demo-1"}, {"name": "demo-2"}],
281+
},
282+
}
283+
284+
# Act
285+
error = decoder.validate_job_schema(text)
286+
287+
# Assert
288+
assert error == "'ordinal' is a required property"

0 commit comments

Comments
 (0)