build: update pnpm and simplify skipping linting in docker builds

Author: OliverDudgeon

.devcontainer/devcontainer.json

@@ -6,7 +6,7 @@
   "image": "mcr.microsoft.com/devcontainers/javascript-node:1-18",
   "features": {
     "ghcr.io/devcontainers-contrib/features/pnpm:2": {
-      "version": "9.12.3"
+      "version": "10.9.0"
     }
   },
   // Features to add to the dev container. More info: https://containers.dev/features.

.github/renovate.json

@@ -15,7 +15,7 @@
     "dependencies"
   ],
   "constraints": {
-    "pnpm": "9"
+    "pnpm": "10"
   },
   "packageRules": [
     {

.github/workflows/lint.yaml

@@ -29,7 +29,7 @@ jobs:
       uses: actions/checkout@v4
     - uses: pnpm/[email protected]
       with:
-        version: 9.12.3
+        version: 10.9.0
         run_install: false
     - name: Setup Node
       uses: actions/setup-node@v4
@@ -48,15 +48,15 @@ jobs:
       uses: actions/checkout@v4
     - uses: pnpm/[email protected]
       with:
-        version: 9.12.3
+        version: 10.9.0
         run_install: false
     - name: Setup Node
       uses: actions/setup-node@v4
       with:
         node-version: 20
         cache: 'pnpm'
     - name: Install dependencies
-      run: pnpm install
+      run: pnpm install --frozen-lockfile
     - run: node -v
     - name: Type Check
       run: pnpm tsc

.github/workflows/nextjs_bundle_analysis.yaml

@@ -20,7 +20,7 @@ jobs:
 
     - uses: pnpm/[email protected]
       with:
-        version: 9.12.3
+        version: 10.9.0
         run_install: false
     - name: Setup Node
       uses: actions/setup-node@v4

.github/workflows/test.yaml

@@ -49,7 +49,7 @@ jobs:
       uses: actions/checkout@v4
     - uses: pnpm/[email protected]
       with:
-        version: 9.12.3
+        version: 10.9.0
         run_install: false
     - name: Setup Node
       uses: actions/setup-node@v4
@@ -123,7 +123,7 @@ jobs:
       uses: actions/checkout@v4
     - uses: pnpm/[email protected]
       with:
-        version: 9.12.3
+        version: 10.9.0
         run_install: false
     - name: Setup Node
       uses: actions/setup-node@v4

Dockerfile

@@ -8,20 +8,11 @@ WORKDIR /app
 COPY package.json pnpm-lock.yaml ./
 COPY patches ./patches/
 
-# Whether to skip TSC and Eslint Checks
-ARG SKIP_CHECKS
-ENV SKIP_CHECKS=${SKIP_CHECKS:-0}
-RUN echo "SKIP_CHECKS=${SKIP_CHECKS}"
-
-RUN npm i -g [email protected]
-RUN if [ "$SKIP_CHECKS" = "1" ]; then pnpm fetch --prod; else pnpm fetch; fi
-RUN if [ "$SKIP_CHECKS" = "1" ]; \
-    then pnpm i -P --ignore-scripts; \
-    else pnpm i --ignore-scripts; fi
-
-# If using npm with a `package-lock.json` comment out above and use below instead
-# COPY package.json package-lock.json ./
-# RUN npm ci
+RUN npm i -g [email protected]
+RUN pnpm fetch --prod
+# RUN pnpm fetch
+RUN pnpm i -P --ignore-scripts
+# RUN pnpm i --ignore-scripts
 
 # Rebuild the source code only when needed
 FROM base AS builder
@@ -41,7 +32,7 @@ ENV GIT_SHA=${GIT_SHA:-""}
 ARG BASE_PATH
 ENV BASE_PATH=${BASE_PATH}
 
-# RUN npm i -g pnpm@9.12.3
+# RUN npm i -g pnpm@10.9.0
 RUN echo "GIT_SHA=${GIT_SHA}" && npm run build
 
 # If using npm comment out above and use below instead

README.md

@@ -90,7 +90,6 @@ build commands, which can be run from the project clone to produce an
 
     $ docker build . \
         --build-arg GIT_SHA=$(git rev-parse HEAD) \
-        --build-arg SKIP_CHECKS=1 \
         --tag informaticsmatters/squonk-data-manager-ui:latest
 
 Deployment to Kubernetes is handled by our AWX-compliant [Ansible playbook repo].
@@ -107,7 +106,6 @@ Build the image using
     $ docker build . \
         --build-arg FLAVOUR=local.example \
         --build-arg GIT_SHA=$(git rev-parse HEAD) \
-        --build-arg SKIP_CHECKS=1 \
         --build-arg BASE_PATH="" \
         --tag informaticsmatters/squonk-data-manager-ui:latest
 

next.config.ts

@@ -30,8 +30,8 @@ const resolvePackage = (packageName: string) =>
 let nextConfig: NextConfig = {
   output: process.env.OUTPUT_TYPE as NextConfig["output"],
   generateBuildId: process.env.GIT_SHA ? () => process.env.GIT_SHA ?? null : undefined,
-  typescript: { ignoreBuildErrors: !!process.env.SKIP_CHECKS },
-  eslint: { ignoreDuringBuilds: !!process.env.SKIP_CHECKS },
+  typescript: { ignoreBuildErrors: true },
+  eslint: { ignoreDuringBuilds: true },
   // reactStrictMode: true, // TODO: Blocked by @rjsf Form using UNSAFE_componentWillReceiveProps
   pageExtensions: ["js", "ts", "jsx", "tsx", "mdx"],
   // replace empty string with undefined