fix(datasets-page): stop request spam when upload finishes

Author: OliverDudgeon

features/DatasetUpload/BulkUploadDropzone.tsx

@@ -1,4 +1,4 @@
-import { type Dispatch, type SetStateAction, useCallback } from "react";
+import { type Dispatch, type SetStateAction } from "react";
 
 import { Grid } from "@mui/material";
 
@@ -55,10 +55,10 @@ const SingleFile = ({ index, file, setFiles, files }: SingleFileProps) => {
     setFiles((curr) => curr.filter((fw) => fw.file !== file));
   };
 
-  const changeToDone = useCallback(() => {
+  const changeToDone = () => {
     file.done = true;
     setFiles(mutateAtPosition(files, index, files[index]));
-  }, [file, files, index, setFiles]);
+  };
 
   const changeMimeType = (newType: string): void => {
     file.mimeType = newType;

features/DatasetUpload/SingleFileUploader.tsx

@@ -50,15 +50,17 @@ export const SingleFileUploadWithProgress = ({
       refetchInterval: interval,
     },
   });
+  const taskDone = task?.done;
 
   useEffect(() => {
-    if (task?.done) {
+    if (taskDone) {
       setInterval(false);
       void queryClient
         .invalidateQueries({ queryKey: getGetDatasetsQueryKey() })
         .then(() => changeToDone());
     }
-  }, [changeToDone, queryClient, task]);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [queryClient, taskDone]);
 
   const { extensions } = useFileExtensions();
   const mimeLookup = useMimeTypeLookup();