Skip to content

Commit 9b80a16

Browse files
committed
refactor: switch circular progress to linear for job cards
1 parent c7a2e0f commit 9b80a16

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

src/components/runCards/ApplicationCard/ApplicationCard.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { type ApplicationSummary } from "@squonk/data-manager-client";
22

3-
import { CircularProgress } from "@mui/material";
3+
import { CircularProgress, LinearProgress } from "@mui/material";
44
import dynamic from "next/dynamic";
55

66
import { useIsUserAdminOrEditorOfCurrentProject } from "../../../hooks/projectHooks";
@@ -15,7 +15,7 @@ const ApplicationModalButton = dynamic<ApplicationModalButtonProps>(
1515

1616
const InstancesList = dynamic<InstancesListProps>(
1717
() => import("../InstancesList").then((mod) => mod.InstancesList),
18-
{ loading: () => <CircularProgress size="1rem" /> },
18+
{ loading: () => <LinearProgress /> },
1919
);
2020

2121
export interface ApplicationCardProps extends Pick<ApplicationModalButtonProps, "projectId"> {

src/components/runCards/InstancesList.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
import { type InstanceSummary } from "@squonk/data-manager-client";
22
import { useGetInstances } from "@squonk/data-manager-client/instance";
33

4-
import { Box, List, ListItemButton, ListItemText, Typography } from "@mui/material";
4+
import { Box, LinearProgress, List, ListItemButton, ListItemText, Typography } from "@mui/material";
55
import dayjs from "dayjs";
66
import A from "next/link";
77
import { useRouter } from "next/router";
88

99
import { useCurrentProjectId } from "../../hooks/projectHooks";
10-
import { CenterLoader } from "../CenterLoader";
1110
import { LocalTime } from "../LocalTime";
1211

1312
type FilterPredicate = (value: InstanceSummary, index: number, array: InstanceSummary[]) => boolean;
@@ -32,7 +31,7 @@ export const InstancesList = ({ predicate }: InstancesListProps) => {
3231
);
3332

3433
if (instances === undefined) {
35-
return <CenterLoader />;
34+
return <LinearProgress />;
3635
}
3736

3837
if (instances.length === 0) {

src/components/runCards/JobCard/JobCard.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { type JobSummary } from "@squonk/data-manager-client";
22

3-
import { Alert, Chip, CircularProgress, Link, Typography } from "@mui/material";
3+
import { Alert, Chip, LinearProgress, Link, Typography } from "@mui/material";
44
import dynamic from "next/dynamic";
55

66
import { BaseCard } from "../../BaseCard";
@@ -10,7 +10,7 @@ import { RunJobButton, type RunJobButtonProps } from "./RunJobButton";
1010

1111
const InstancesList = dynamic<InstancesListProps>(
1212
() => import("../InstancesList").then((mod) => mod.InstancesList),
13-
{ loading: () => <CircularProgress size="1rem" /> },
13+
{ loading: () => <LinearProgress /> },
1414
);
1515

1616
export interface ApplicationCardProps extends Pick<RunJobButtonProps, "projectId"> {

0 commit comments

Comments
 (0)